[STK-249][FIX] - Stackbox start date fails TX creation #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
berteotti
approved these changes
Jul 25, 2024
Diogomartf
approved these changes
Jul 25, 2024
ElRodrigote
deleted the
fix/stk-249-stackbox-start-date-fails-tx-creation
branch
Diogomartf
added a commit
that referenced
this pull request
Jul 30, 2024
* Add new tokens (#188) - add new cow token logo - add shutter and olas to gnosis tokenlist * fix(STK-255): My Stacks breaks for some one time orders (#189) * fix: add safeguards to check if the active order has orderSlots * fix: make 1 slot orders cancellable under correct scenarios * fix: update confirmation stack logic to handle a minimum date of now + 10 mins (#190) * fix(STK-253): My Stacks displaying NaN (#191) * fix: use the start date to compute the 'Next Order' for orders with no slots * fix: if there's no executed buy amount, return 0 to compute the avg buy price * fix: hide stacks details if the end date is equal or less than the start date (#192) --------- Co-authored-by: Rorry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: STK-249
Description
Visual Evidence
https://www.loom.com/share/434fe59f8a3a4019874864c2c29fb64b?sid=2731eb81-3b8e-4acd-8865-c5bd6ffcaa88