hide chart if reports are not from simplecov

Superfiliate · Dec 23, 2024 · 509f4e3 · 509f4e3
1 parent de7201b
commit 509f4e3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/app/services/projects/simplecov_progress.rb b/app/services/projects/simplecov_progress.rb
@@ -9,7 +9,7 @@ def initialize(project)
     def call
       # TODO: could be improved to only get the last report of each date.
       # TODO: could be improved to remove blank coverage reports at the SQL level.
-      project.reports.where(branch: "main").order(:created_at).map do |report|
+      project.reports.simplecov.where(branch: "main").order(:created_at).map do |report|
         next if report.general_coverage.blank?
 
         [ report.created_at, report.general_coverage ]

diff --git a/app/views/projects/show.html.erb b/app/views/projects/show.html.erb
@@ -2,12 +2,14 @@
 <h5>Project</h5>
 <h1><%= @project.handle %></h1>
 
-<%=
-  line_chart(
-    simplecov_progress,
-    library: { scales: { y: { type: 'logarithmic' } } }
-  )
-%>
+<% if simplecov_progress.present? %>
+  <%=
+    line_chart(
+      simplecov_progress,
+      library: { scales: { y: { type: 'logarithmic' } } }
+    )
+  %>
+<% end %>
 
 <div>
   <ul class="list-disc">