Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

feat: comments component #288

Merged
merged 98 commits into from
Oct 3, 2023
Merged

feat: comments component #288

merged 98 commits into from
Oct 3, 2023

Conversation

vitorvargasdev
Copy link
Contributor

No description provided.

@vitorvargasdev vitorvargasdev marked this pull request as draft August 4, 2023 04:06
@vitorvargasdev vitorvargasdev changed the title Comments Component feat: comments component Aug 4, 2023
@SuperViz-Dev
Copy link
Contributor

Total Coverage: 92.13%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
   shims.d.ts 100% 100% 100%
src/common
src/common/styles
   videoConferenceStyle.ts 100% 100% 100%
src/common/types
   events.types.ts 100% 100% 100%
   meeting-colors.types.ts 100% 100% 100%
   participant.types.ts 100% 100% 100%
   realtime.types.ts 100% 100% 100%
   sdk-options.types.ts 100% 100% 100%
src/common/utils
   do-request.ts 100% 100% 100%
   index.ts 100% 100% 100%
   logger.ts 100% 100% 100%
   observer.ts 100% 100% 100%
   sleep.ts 0% 100% 100% 2
src/components
   index.ts 100% 50% 100%
src/components/base
   index.ts 100% 100% 100%
src/components/comments
   index.ts 100% 80% 92.86% 32
src/components/video
   index.ts 95.65% 100% 100% 81
src/core
   index.ts 88.89% 100% 87.50% 49, 50, 67, 71, 73, 83
src/core/launcher
   index.ts 100% 100% 100%
src/services
src/services/api
   index.ts 100% 100% 100%
src/services/auth-service
   index.ts 100% 100% 100%
src/services/browser
   index.ts 100% 100% 100%
src/services/config
   index.ts 100% 100% 100%
src/services/connection-status
   index.ts 100% 100% 100%
src/services/frame-brick-layer
   index.ts 100% 100% 100%
src/services/integration
   index.ts 75% 94.44% 92.86% 212, 233, 234, 246, 247, 248, 248, 249, 27, 28, 29, 59, 73
src/services/integration/base-plugin
   index.ts 68.42% 77.27% 82.81% 136, 137, 141, 142, 169, 170, 173, 174, 197, 198, 201, 206, 41, 44, 47, 50, 53
src/services/integration/participants
   index.ts 100% 100% 100%
src/services/message-bridge
   index.ts 93.33% 100% 100% 80
src/services/pubsub
   index.ts 100% 100% 100%
src/services/realtime
   index.ts 100% 100% 100%
src/services/realtime/ably
   index.ts 70.83% 69.88% 79.49% 103, 1054, 107, 108, 178, 254, 410, 488, 489, 491, 492, 494, 494, 507, 508, 510, 520, 521, 522, 523, 524, 524, 525, 526, 538, 548, 550, 552, 552, 552, 553, 554, 554, 555, 558, 560, 560, 560, 560, 561, 562, 592, 602, 644, 645, 673, 674, 675, 676, 676, 677, 679, 683, 683, 683, 683, 684, 685, 688, 688, 689, 692, 693, 695, 700, 800, 800, 801, 804, 806, 806, 806, 807, 809, 863, 865, 866, 868, 870, 873, 873, 873, 873, 874, 875, 877, 880, 883, 883, 884, 906, 907, 91, 931, 942, 943, 944, 945, 946, 946, 947, 949, 949, 95, 950, 950, 953, 957, 957, 957, 958, 958, 961, 964, 965, 99
src/services/realtime/base
   index.ts 100% 100% 100%
src/services/remote-config-service
   index.ts 100% 100% 100%
src/services/video-conference-manager
   index.ts 60.98% 88.57% 92.19% 118, 122, 123, 124, 165, 171, 203, 204, 209, 210, 211, 214, 214, 215, 217, 218, 291, 327, 328, 329, 332, 333, 334, 387, 421, 532, 544, 587, 95, 96, 97
   types.ts 100% 100% 100%

carlossantos74
carlossantos74 reviewed Aug 9, 2023
View reviewed changes
src/components/comments/index.test.ts Show resolved Hide resolved
src/components/comments/index.test.ts Outdated Show resolved Hide resolved
src/components/comments/index.ts Outdated Show resolved Hide resolved
instalando and others added 12 commits August 17, 2023 12:24
@SuperViz-Dev
Copy link
Contributor

Total Coverage: 97.77%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
src/web-components
src/web-components/base
   index.ts 100% 100% 100%
src/web-components/base/styles
   index.ts 100% 100% 100%
   sv-hr.style.ts 100% 100% 100%
   typography.style.ts 100% 100% 100%
   variables.style.ts 100% 100% 100%
src/web-components/comments
   comments.ts 100% 100% 100%
   index.ts 100% 100% 100%
src/web-components/comments/components
   annotation-item.ts 82.35% 87.50% 91.74% 46, 54, 66, 67, 68, 69, 70, 71, 72, 73, 79, 80
   annotation-pin.ts 100% 100% 100%
   annotations.ts 100% 66.67% 87.18% 21, 22, 23, 24, 25
   comment-input.ts 75% 100% 93.41% 30, 31, 32, 33, 35, 36, 37, 38
   comment-item.ts 100% 100% 100%
   content.ts 100% 100% 100%
   index.ts 100% 100% 100%
   topbar.ts 100% 100% 100%
src/web-components/comments/css
   annotation-item.style.ts 100% 100% 100%
   annotations.style.ts 100% 100% 100%
   comment-input.style.ts 100% 100% 100%
   comment-item.style.ts 100% 100% 100%
   comments.style.ts 100% 100% 100%
   content.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   topbar.style.ts 100% 100% 100%
src/web-components/hello-world
   index.ts 100% 100% 100%

@SuperViz-Dev
Copy link
Contributor

Total Coverage: 92.22%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
   shims.d.ts 100% 100% 100%
src/common
src/common/styles
   videoConferenceStyle.ts 100% 100% 100%
src/common/types
   events.types.ts 100% 100% 100%
   meeting-colors.types.ts 100% 100% 100%
   participant.types.ts 100% 100% 100%
   realtime.types.ts 100% 100% 100%
   sdk-options.types.ts 100% 100% 100%
src/common/utils
   do-request.ts 100% 100% 100%
   index.ts 100% 100% 100%
   logger.ts 100% 100% 100%
   observer.ts 100% 100% 100%
   sleep.ts 0% 100% 100% 2
src/components
   index.ts 100% 100% 100%
src/components/base
   index.ts 100% 100% 100%
src/components/comments
   index.ts 100% 66.67% 75% 101, 115, 135, 75, 76, 78, 85, 87
src/components/video
   index.ts 95.65% 100% 100% 81
src/core
   index.ts 88.89% 100% 87.50% 49, 50, 67, 71, 73, 83
src/core/launcher
   index.ts 100% 100% 100%
src/services
src/services/api
   index.ts 100% 100% 100%
src/services/auth-service
   index.ts 100% 100% 100%
src/services/browser
   index.ts 100% 100% 100%
src/services/config
   index.ts 100% 100% 100%
src/services/connection-status
   index.ts 100% 100% 100%
src/services/event-bus
   index.ts 100% 100% 100%
src/services/frame-brick-layer
   index.ts 100% 100% 100%
src/services/message-bridge
   index.ts 93.33% 100% 100% 80
src/services/pubsub
   index.ts 100% 100% 100%
src/services/realtime
   index.ts 100% 100% 100%
src/services/realtime/ably
   index.ts 70.25% 69.88% 79.44% 103, 1052, 107, 108, 178, 254, 410, 488, 489, 491, 492, 494, 494, 507, 508, 510, 520, 521, 522, 523, 524, 524, 525, 526, 538, 548, 550, 552, 552, 552, 553, 554, 554, 555, 558, 560, 560, 560, 560, 561, 562, 572, 590, 600, 642, 643, 671, 672, 673, 674, 674, 675, 677, 681, 681, 681, 681, 682, 683, 686, 686, 687, 690, 691, 693, 698, 798, 798, 799, 802, 804, 804, 804, 805, 807, 861, 863, 864, 866, 868, 871, 871, 871, 871, 872, 873, 875, 878, 881, 881, 882, 904, 905, 91, 929, 940, 941, 942, 943, 944, 944, 945, 947, 947, 948, 948, 95, 951, 955, 955, 955, 956, 956, 959, 962, 963, 99
src/services/realtime/base
   index.ts 100% 100% 100%
src/services/remote-config-service
   index.ts 100% 100% 100%
src/services/video-conference-manager
   index.ts 60.98% 88.57% 92.19% 118, 122, 123, 124, 165, 171, 203, 204, 209, 210, 211, 214, 214, 215, 217, 218, 291, 327, 328, 329, 332, 333, 334, 387, 421, 532, 544, 587, 95, 96, 97
   types.ts 100% 100% 100%

@SuperViz-Dev
Copy link
Contributor

Total Coverage: 92.32%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
   shims.d.ts 100% 100% 100%
src/common
src/common/styles
   videoConferenceStyle.ts 100% 100% 100%
src/common/types
   events.types.ts 100% 100% 100%
   meeting-colors.types.ts 100% 100% 100%
   participant.types.ts 100% 100% 100%
   realtime.types.ts 100% 100% 100%
   sdk-options.types.ts 100% 100% 100%
src/common/utils
   do-request.ts 100% 100% 100%
   index.ts 100% 100% 100%
   logger.ts 100% 100% 100%
   observer.ts 100% 100% 100%
   sleep.ts 0% 100% 100% 2
src/components
   index.ts 100% 100% 100%
src/components/base
   index.ts 100% 100% 100%
src/components/comments
   index.ts 100% 100% 82.61% 115, 116, 149, 150, 169, 170, 95, 96
src/components/video
   index.ts 94.74% 100% 100% 102
src/core
   index.ts 88.89% 100% 87.50% 49, 50, 67, 71, 73, 83
src/core/launcher
   index.ts 100% 100% 100%
src/services
src/services/api
   index.ts 100% 100% 100%
src/services/auth-service
   index.ts 100% 100% 100%
src/services/browser
   index.ts 100% 100% 100%
src/services/config
   index.ts 100% 100% 100%
src/services/connection-status
   index.ts 100% 100% 100%
src/services/event-bus
   index.ts 100% 100% 100%
src/services/frame-brick-layer
   index.ts 100% 100% 100%
src/services/message-bridge
   index.ts 93.33% 100% 100% 80
src/services/pubsub
   index.ts 100% 100% 100%
src/services/realtime
   index.ts 100% 100% 100%
src/services/realtime/ably
   index.ts 70.25% 69.88% 79.44% 103, 1052, 107, 108, 178, 254, 410, 488, 489, 491, 492, 494, 494, 507, 508, 510, 520, 521, 522, 523, 524, 524, 525, 526, 538, 548, 550, 552, 552, 552, 553, 554, 554, 555, 558, 560, 560, 560, 560, 561, 562, 572, 590, 600, 642, 643, 671, 672, 673, 674, 674, 675, 677, 681, 681, 681, 681, 682, 683, 686, 686, 687, 690, 691, 693, 698, 798, 798, 799, 802, 804, 804, 804, 805, 807, 861, 863, 864, 866, 868, 871, 871, 871, 871, 872, 873, 875, 878, 881, 881, 882, 904, 905, 91, 929, 940, 941, 942, 943, 944, 944, 945, 947, 947, 948, 948, 95, 951, 955, 955, 955, 956, 956, 959, 962, 963, 99
src/services/realtime/base
   index.ts 100% 100% 100%
src/services/remote-config-service
   index.ts 100% 100% 100%
src/services/video-conference-manager
   index.ts 60.98% 88.57% 92.19% 118, 122, 123, 124, 165, 171, 203, 204, 209, 210, 211, 214, 214, 215, 217, 218, 291, 327, 328, 329, 332, 333, 334, 387, 421, 532, 544, 587, 95, 96, 97
   types.ts 100% 100% 100%

@carlossantos74
feat(wip): render annotations on canvas
956770d
@carlossantos74
feat: render pins into canvas
84e543c
@carlossantos74
feat: create temporary pin while a new annotation is creating
cc80ccf
@carlossantos74
fix: fix coordinates to save
92330e5
@carlossantos74
feat: remove all pins when isActive turned false
ff8c5d1
@carlossantos74
fix: annotations styles
65c8ac1
@carlossantos74
fix: coordinates spell check
6d38698
@carlossantos74
test: improve test coverage
154fa10
@carlossantos74
test: fix annotation-pin tests
86352f2
@carlossantos74
feat: select annotation by pin
5ab9481
@carlossantos74
refactor: pin option case and unecessary imports
3b67ca9
@carlossantos74
Merge pull request #342 from SuperViz/refactor/improve-and-fix-some-bugs
a327a10 
refactor: improve and fix some bugs
@carlossantos74
Merge branch 'lab' of github.com:SuperViz/sdk into update-comments-wi…
9b03aea 
…th-lab
@carlossantos74
Merge pull request #349 from SuperViz/update-comments-with-lab
0788b8f 
Update comments with lab
@SuperViz-Dev
Copy link
Contributor

Total Coverage: 92.78%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
   shims.d.ts 100% 100% 100%
src/common
src/common/types
   events.types.ts 100% 100% 100%
   meeting-colors.types.ts 100% 100% 100%
   participant.types.ts 100% 100% 100%
   realtime.types.ts 100% 100% 100%
   sdk-options.types.ts 100% 100% 100%
src/common/utils
   do-request.ts 100% 100% 100%
   index.ts 100% 100% 100%
   logger.ts 100% 100% 100%
   observer.ts 100% 100% 100%
   sleep.ts 0% 100% 100% 2
src/components
   index.ts 100% 66.67% 100%
   types.ts 100% 100% 100%
src/components/base
   index.ts 100% 100% 100%
src/components/comments
   index.ts 83.33% 92.31% 96.30% 301, 301, 302, 305, 82
src/components/presence-mouse
   index.ts 73.91% 100% 100% 133, 84, 91, 92, 93, 94
src/components/video
   index.ts 100% 100% 100%
src/core
   index.ts 88.89% 100% 87.88% 49, 50, 68, 72, 74, 85
src/core/launcher
   index.ts 92.31% 95% 95.05% 280, 282, 282, 283, 284, 286
src/services
src/services/api
   index.ts 100% 92.86% 93.75% 89, 90, 92
src/services/auth-service
   index.ts 100% 100% 100%
src/services/browser
   index.ts 100% 100% 100%
src/services/config
   index.ts 100% 100% 100%
src/services/connection-status
   index.ts 100% 100% 100%
src/services/event-bus
   index.ts 100% 100% 100%
src/services/frame-brick-layer
   index.ts 100% 100% 100%
src/services/limits
   index.ts 100% 100% 100%
src/services/message-bridge
   index.ts 93.33% 100% 100% 80
src/services/pubsub
   index.ts 100% 100% 100%
src/services/realtime
   index.ts 100% 100% 100%
src/services/realtime/ably
   index.ts 68.85% 69.05% 78.48% 100, 104, 105, 1058, 1067, 1069, 1069, 1070, 1167, 1168, 1172, 175, 255, 411, 489, 490, 492, 493, 495, 495, 508, 509, 511, 521, 522, 523, 524, 525, 525, 526, 527, 539, 549, 551, 553, 553, 553, 554, 555, 556, 556, 557, 560, 562, 562, 562, 562, 563, 564, 574, 592, 602, 644, 645, 673, 674, 675, 676, 676, 677, 679, 683, 683, 683, 683, 684, 685, 688, 688, 689, 690, 693, 694, 696, 701, 801, 801, 802, 805, 807, 807, 807, 808, 810, 864, 866, 867, 869, 871, 874, 874, 874, 874, 875, 876, 877, 879, 88, 882, 885, 885, 886, 908, 909, 92, 933, 944, 945, 946, 947, 948, 948, 949, 951, 951, 952, 952, 955, 959, 959, 959, 960, 960, 963, 966, 967
src/services/realtime/base
   index.ts 100% 100% 100%
src/services/remote-config-service
   index.ts 100% 100% 100%
src/services/video-conference-manager
   index.ts 64.10% 86.11% 93.62% 108, 112, 113, 114, 154, 160, 192, 193, 198, 199, 200, 203, 203, 204, 206, 207, 284, 319, 320, 321, 374, 408, 519, 531, 574, 578
   types.ts 100% 100% 100%

@SuperViz-Dev
Copy link
Contributor

Total Coverage: 99.83%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
src/web-components
src/web-components/base
   index.ts 100% 100% 100%
src/web-components/base/styles
   icon-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   sv-hr.style.ts 100% 100% 100%
   typography.style.ts 100% 100% 100%
   variables.style.ts 100% 100% 100%
src/web-components/comments
   comments.ts 100% 100% 100%
   index.ts 100% 100% 100%
src/web-components/comments/components
   annotation-filter.ts 100% 100% 100%
   annotation-item.ts 100% 100% 100%
   annotation-pin.ts 100% 100% 100%
   annotation-resolved.ts 100% 100% 100%
   annotations.ts 100% 100% 100%
   comment-input.ts 100% 100% 100%
   comment-item.ts 100% 100% 100%
   content.ts 100% 100% 100%
   delete-comment-modal.ts 100% 100% 100%
   index.ts 100% 100% 100%
   topbar.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/comments/css
   annotation-filter.style.ts 100% 100% 100%
   annotation-item.style.ts 100% 100% 100%
   annotation-resolved.style.ts 100% 100% 100%
   annotations.style.ts 100% 100% 100%
   comment-input.style.ts 100% 100% 100%
   comment-item.style.ts 100% 100% 100%
   comments.style.ts 100% 100% 100%
   content.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   topbar.style.ts 100% 100% 100%
src/web-components/dropdown
   index.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
src/web-components/hello-world
   index.ts 100% 100% 100%
src/web-components/icon
   index.ts 100% 100% 100%
src/web-components/modal
   index.ts 100% 100% 100%
   modal-container.ts 100% 100% 100%
   modal.ts 100% 100% 100%
src/web-components/modal/styles
   index.style.ts 100% 100% 100%
src/web-components/presence-mouse
   index.ts 66.67% 100% 96.33% 42, 43, 44, 59, 60, 69, 70, 76, 77
   styles.ts 100% 100% 100%

@SuperViz-Dev
Copy link
Contributor

Total Coverage: 93.13%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
   shims.d.ts 100% 100% 100%
src/common
src/common/types
   events.types.ts 100% 100% 100%
   meeting-colors.types.ts 100% 100% 100%
   participant.types.ts 100% 100% 100%
   realtime.types.ts 100% 100% 100%
   sdk-options.types.ts 100% 100% 100%
src/common/utils
   do-request.ts 100% 100% 100%
   index.ts 100% 100% 100%
   logger.ts 100% 100% 100%
   observer.ts 100% 100% 100%
   sleep.ts 0% 100% 100% 2
src/components
   index.ts 100% 50% 100%
   types.ts 100% 100% 100%
src/components/base
   index.ts 100% 100% 100%
src/components/comments
   index.ts 83.33% 92.86% 96.92% 104, 376, 376, 377, 380
src/components/comments/canvas-pin-adapter
   index.ts 82.35% 95% 96.58% 229, 271, 273, 273, 274, 277, 304
src/components/presence-mouse
   index.ts 73.91% 100% 100% 133, 84, 91, 92, 93, 94
src/components/video
   index.ts 100% 100% 100%
src/core
   index.ts 88.89% 100% 87.88% 49, 50, 68, 72, 74, 85
src/core/launcher
   index.ts 92.31% 95% 95.05% 280, 282, 282, 283, 284, 286
src/services
src/services/api
   index.ts 100% 92.86% 93.75% 89, 90, 92
src/services/auth-service
   index.ts 100% 100% 100%
src/services/browser
   index.ts 100% 100% 100%
src/services/config
   index.ts 100% 100% 100%
src/services/connection-status
   index.ts 100% 100% 100%
src/services/event-bus
   index.ts 100% 100% 100%
src/services/frame-brick-layer
   index.ts 100% 100% 100%
src/services/limits
   index.ts 100% 100% 100%
src/services/message-bridge
   index.ts 93.33% 100% 100% 80
src/services/pubsub
   index.ts 100% 100% 100%
src/services/realtime
   index.ts 100% 100% 100%
src/services/realtime/ably
   index.ts 68.85% 69.05% 78.48% 100, 104, 105, 1058, 1067, 1069, 1069, 1070, 1167, 1168, 1172, 175, 255, 411, 489, 490, 492, 493, 495, 495, 508, 509, 511, 521, 522, 523, 524, 525, 525, 526, 527, 539, 549, 551, 553, 553, 553, 554, 555, 556, 556, 557, 560, 562, 562, 562, 562, 563, 564, 574, 592, 602, 644, 645, 673, 674, 675, 676, 676, 677, 679, 683, 683, 683, 683, 684, 685, 688, 688, 689, 690, 693, 694, 696, 701, 801, 801, 802, 805, 807, 807, 807, 808, 810, 864, 866, 867, 869, 871, 874, 874, 874, 874, 875, 876, 877, 879, 88, 882, 885, 885, 886, 908, 909, 92, 933, 944, 945, 946, 947, 948, 948, 949, 951, 951, 952, 952, 955, 959, 959, 959, 960, 960, 963, 966, 967
src/services/realtime/base
   index.ts 100% 100% 100%
src/services/remote-config-service
   index.ts 100% 100% 100%
src/services/video-conference-manager
   index.ts 64.10% 86.11% 93.62% 108, 112, 113, 114, 154, 160, 192, 193, 198, 199, 200, 203, 203, 204, 206, 207, 284, 319, 320, 321, 374, 408, 519, 531, 574, 578
   types.ts 100% 100% 100%

@SuperViz-Dev
Copy link
Contributor

Total Coverage: 99.73%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
src/web-components
src/web-components/base
   index.ts 100% 100% 100%
src/web-components/base/styles
   icon-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   sv-hr.style.ts 100% 100% 100%
   typography.style.ts 100% 100% 100%
   variables.style.ts 100% 100% 100%
src/web-components/comments
   comments.ts 100% 83.33% 97.10% 38, 39
   index.ts 100% 100% 100%
src/web-components/comments/components
   annotation-filter.ts 100% 100% 100%
   annotation-item.ts 100% 100% 100%
   annotation-pin.ts 100% 100% 100%
   annotation-resolved.ts 100% 100% 100%
   annotations.ts 100% 100% 100%
   comment-input.ts 96.77% 100% 100% 56
   comment-item.ts 100% 100% 100%
   content.ts 100% 100% 98.90% 86
   delete-comment-modal.ts 100% 100% 100%
   float-button.ts 100% 100% 100%
   index.ts 100% 100% 100%
   topbar.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/comments/css
   annotation-filter.style.ts 100% 100% 100%
   annotation-item.style.ts 100% 100% 100%
   annotation-pin.style.ts 100% 100% 100%
   annotation-resolved.style.ts 100% 100% 100%
   annotations.style.ts 100% 100% 100%
   comment-input.style.ts 100% 100% 100%
   comment-item.style.ts 100% 100% 100%
   comments.style.ts 100% 100% 100%
   content.style.ts 100% 100% 100%
   float-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   topbar.style.ts 100% 100% 100%
src/web-components/dropdown
   index.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
src/web-components/hello-world
   index.ts 100% 100% 100%
src/web-components/icon
   index.ts 100% 100% 100%
src/web-components/modal
   index.ts 100% 100% 100%
   modal-container.ts 100% 100% 100%
   modal.ts 100% 100% 100%
src/web-components/modal/styles
   index.style.ts 100% 100% 100%
src/web-components/presence-mouse
   index.ts 66.67% 100% 96.33% 42, 43, 44, 59, 60, 69, 70, 76, 77
   styles.ts 100% 100% 100%

@carlossantos74 carlossantos74 marked this pull request as ready for review October 3, 2023 16:58
@SuperViz-Dev
Copy link
Contributor

Total Coverage: 99.73%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
src/web-components
src/web-components/base
   index.ts 100% 100% 100%
src/web-components/base/styles
   icon-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   sv-hr.style.ts 100% 100% 100%
   typography.style.ts 100% 100% 100%
   variables.style.ts 100% 100% 100%
src/web-components/comments
   comments.ts 100% 83.33% 97.10% 38, 39
   index.ts 100% 100% 100%
src/web-components/comments/components
   annotation-filter.ts 100% 100% 100%
   annotation-item.ts 100% 100% 100%
   annotation-pin.ts 100% 100% 100%
   annotation-resolved.ts 100% 100% 100%
   annotations.ts 100% 100% 100%
   comment-input.ts 96.77% 100% 100% 56
   comment-item.ts 100% 100% 100%
   content.ts 100% 100% 98.90% 86
   delete-comment-modal.ts 100% 100% 100%
   float-button.ts 100% 100% 100%
   index.ts 100% 100% 100%
   topbar.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/comments/css
   annotation-filter.style.ts 100% 100% 100%
   annotation-item.style.ts 100% 100% 100%
   annotation-pin.style.ts 100% 100% 100%
   annotation-resolved.style.ts 100% 100% 100%
   annotations.style.ts 100% 100% 100%
   comment-input.style.ts 100% 100% 100%
   comment-item.style.ts 100% 100% 100%
   comments.style.ts 100% 100% 100%
   content.style.ts 100% 100% 100%
   float-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   topbar.style.ts 100% 100% 100%
src/web-components/dropdown
   index.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
src/web-components/hello-world
   index.ts 100% 100% 100%
src/web-components/icon
   index.ts 100% 100% 100%
src/web-components/modal
   index.ts 100% 100% 100%
   modal-container.ts 100% 100% 100%
   modal.ts 100% 100% 100%
src/web-components/modal/styles
   index.style.ts 100% 100% 100%
src/web-components/presence-mouse
   index.ts 66.67% 100% 96.33% 42, 43, 44, 59, 60, 69, 70, 76, 77
   styles.ts 100% 100% 100%

@SuperViz-Dev
Copy link
Contributor

Total Coverage: 93.14%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
   shims.d.ts 100% 100% 100%
src/common
src/common/types
   events.types.ts 100% 100% 100%
   meeting-colors.types.ts 100% 100% 100%
   participant.types.ts 100% 100% 100%
   realtime.types.ts 100% 100% 100%
   sdk-options.types.ts 100% 100% 100%
src/common/utils
   do-request.ts 100% 100% 100%
   index.ts 100% 100% 100%
   logger.ts 100% 100% 100%
   observer.ts 100% 100% 100%
   sleep.ts 0% 100% 100% 2
src/components
   index.ts 100% 50% 100%
   types.ts 100% 100% 100%
src/components/base
   index.ts 100% 100% 100%
src/components/comments
   index.ts 83.33% 92.86% 96.92% 104, 376, 376, 377, 380
src/components/comments/canvas-pin-adapter
   index.ts 82.35% 95% 96.58% 229, 271, 273, 273, 274, 277, 304
src/components/presence-mouse
   index.ts 73.91% 100% 100% 133, 84, 91, 92, 93, 94
src/components/video
   index.ts 100% 100% 100%
src/core
   index.ts 80% 100% 88.24% 49, 50, 68, 72, 74, 85, 89, 89
src/core/launcher
   index.ts 92.31% 95% 95.05% 280, 282, 282, 283, 284, 286
src/services
src/services/api
   index.ts 100% 92.86% 93.75% 89, 90, 92
src/services/auth-service
   index.ts 100% 100% 100%
src/services/browser
   index.ts 100% 100% 100%
src/services/config
   index.ts 100% 100% 100%
src/services/connection-status
   index.ts 100% 100% 100%
src/services/event-bus
   index.ts 100% 100% 100%
src/services/frame-brick-layer
   index.ts 100% 100% 100%
src/services/limits
   index.ts 100% 100% 100%
src/services/message-bridge
   index.ts 93.33% 100% 100% 80
src/services/pubsub
   index.ts 100% 100% 100%
src/services/realtime
   index.ts 100% 100% 100%
src/services/realtime/ably
   index.ts 68.85% 69.05% 78.48% 100, 104, 105, 1058, 1067, 1069, 1069, 1070, 1167, 1168, 1172, 175, 255, 411, 489, 490, 492, 493, 495, 495, 508, 509, 511, 521, 522, 523, 524, 525, 525, 526, 527, 539, 549, 551, 553, 553, 553, 554, 555, 556, 556, 557, 560, 562, 562, 562, 562, 563, 564, 574, 592, 602, 644, 645, 673, 674, 675, 676, 676, 677, 679, 683, 683, 683, 683, 684, 685, 688, 688, 689, 690, 693, 694, 696, 701, 801, 801, 802, 805, 807, 807, 807, 808, 810, 864, 866, 867, 869, 871, 874, 874, 874, 874, 875, 876, 877, 879, 88, 882, 885, 885, 886, 908, 909, 92, 933, 944, 945, 946, 947, 948, 948, 949, 951, 951, 952, 952, 955, 959, 959, 959, 960, 960, 963, 966, 967
src/services/realtime/base
   index.ts 100% 100% 100%
src/services/remote-config-service
   index.ts 100% 100% 100%
src/services/video-conference-manager
   index.ts 64.10% 86.11% 93.62% 108, 112, 113, 114, 154, 160, 192, 193, 198, 199, 200, 203, 203, 204, 206, 207, 284, 319, 320, 321, 374, 408, 519, 531, 574, 578
   types.ts 100% 100% 100%

@carlossantos74 carlossantos74 merged commit a805461 into lab Oct 3, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 3, 2023
@carlossantos74
BUILD: (a805461) Merge pull request #288 from SuperViz/feat/comments-…
b3a8572 
…component

feat: comments component
@SuperViz-Dev
Copy link
Contributor

🎉 This PR is included in version 4.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossantos74 carlossantos74 carlossantos74 left review comments

@brunokunace brunokunace Awaiting requested review from brunokunace

@afonsovinicius afonsovinicius Awaiting requested review from afonsovinicius

Assignees

@carlossantos74 carlossantos74

@vitorvargasdev vitorvargasdev

Labels
New feature New feature released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vitorvargasdev @SuperViz-Dev @carlossantos74 @brunokunace @afonsovinicius