Merge pull request #734 from SuperViz/beta

fix: disconnect from drawing room when the video is destroyed
SuperViz · Aug 5, 2024 · 636ed78 · 636ed78
2 parents 4f06d49 + 6805915
commit 636ed78
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 1 deletion.
diff --git a/src/components/video/index.ts b/src/components/video/index.ts
@@ -22,7 +22,7 @@ import { Logger } from '../../common/utils';
 import { BrowserService } from '../../services/browser';
 import config from '../../services/config';
 import { ConnectionService } from '../../services/connection-status';
-import { RoomStateService } from '../../services/roomState';
+import { RoomStateService } from '../../services/room-state';
 import VideoConferenceManager from '../../services/video-conference-manager';
 import {
   CamerasPosition,
@@ -184,6 +184,7 @@ export class VideoConference extends BaseComponent {
     destroy();
 
     this.roomState?.destroy();
+    this.drawingRoom.disconnect();
 
     this.kickParticipantsOnHostLeave = false;
 

diff --git a/src/services/roomState/index.test.ts → src/services/room-state/index.test.ts b/src/services/roomState/index.test.ts → src/services/room-state/index.test.ts
diff --git a/src/services/roomState/index.ts → src/services/room-state/index.ts b/src/services/roomState/index.ts → src/services/room-state/index.ts
@@ -407,6 +407,7 @@ export class RoomStateService {
   public destroy() {
     this.room.presence.off(PresenceEvents.LEAVE);
     this.room.presence.off(PresenceEvents.JOINED_ROOM);
+    this.drawingRoom.presence.off(PresenceEvents.UPDATE);
 
     this.room.off(RoomPropertiesEvents.UPDATE, this.updateLocalRoomState);
   }

diff --git a/src/services/roomState/type.ts → src/services/room-state/type.ts b/src/services/roomState/type.ts → src/services/room-state/type.ts