Mark ambiguous float / long syntax as deprecated #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Microsoft themselves warn against using that kind of notation. Tests changed to reflect the new designation.
|
Deprecated highlighting often results in poor DX when working on legacy code. |
|
Ah I see. I just saw your PR as well, which brings many changes to the syntax, so I guess I can close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft themselves warn against using that kind of notation.
Tests were changed to reflect the new designation. With this, the CI checks shouldn't return any more errors for now!
Thank you Michael and deathaxe for your help so far.