Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added quality-of-life improvments to the black dot optimization #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added quality-of-life improvments to the black dot optimization #48

wants to merge 1 commit into from

Conversation

nevencaplar
Copy link
Member

Added small improvements to the readability and functionality of the code.

  • linting done on the black dot script
  • script can now take only instance (no need to also pass data, as instance contains input data)
  • removed lines which were repeating
  • added fixed random seed

@nevencaplar nevencaplar requested a review from hassanxp June 9, 2022 22:58
hassanxp
hassanxp approved these changes Jun 10, 2022
View reviewed changes
Copy link

@hassanxp hassanxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look fine. Ideally commit should have been split into 3, but not necessary for now.

@nevencaplar
Added quality-of-life improvments to the black dot optimization routi…
ebab566 
…nes, based on the experience of the May 2022 run.

Removed duplicate lines of code
optimize_black_dots_instance now allows to have input data accessible from outside class
	 - this allows the visualizations to take only instance as input
Added possibility to pass a custom random seed to the optimization routine
flake 8 cleaning of the script
@hassanxp hassanxp force-pushed the tickets/PIPE2D-1050 branch from a50b24e to ebab566 Compare August 2, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hassanxp hassanxp hassanxp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nevencaplar @hassanxp