DAMD-89: Document and implement DetectorMap #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
force-pushed
the
tickets/PIPE2D-641
branch
3 times, most recently
from
e2443f1 to
1edbe52
Compare
PaulPrice
force-pushed
the
tickets/DAMD-89
branch
from
97f064e to
b15e025
Compare
PaulPrice
force-pushed
the
tickets/DAMD-89
branch
from
b15e025 to
ff1af47
Compare
added 7 commits
November 16, 2020 17:16
Corrected calculations from AB maginitude to flux [nJy] accordingly.
…Flux The original code assumed AB magnitude as input. It is now AB flux. The reference flux calculation was updated accordingly.
…des. Also renamed local variables from *mag to *flux where appropriate.
and photometry errors fiberFluxErr, psfFluxErr, totalFluxErr
hassanxp
approved these changes
Nov 20, 2020
|
|
||
|
|
||
| def headerToMetadata(header): | ||
| """Convert FITS header to LSST metadata |
There was a problem hiding this comment.
Isn't this something we should move to pfs_utils?
There was a problem hiding this comment.
pfs_utils should know nothing about LSST.
The detectorMap shouldn't be necessary for building a fiber flat: the fibers are dithered.
It's useful to have a temporary directory when running tests. This implementation is taken from LSST's lsst.utils.tests, but it's not in LSST 18.1.0, so reproduced here.
We don't use this anywhere. These days, we'd use ArcLineSet instead.
Getting an afw-format FITS header (PropertyList) seems to be a common enough operation that we should have a separate function for it.
By using the I/O in datamodel, we ensure that we're always writing the correct format, but it means a bit of a refactor. We no longer have to determine the subclass of data on disk (that's done in the datamodel I/O code); now we just have to convert to/from the datamodel representation.
PaulPrice
force-pushed
the
tickets/DAMD-89
branch
from
ff1af47 to
aac8b1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on tickets/PIPE2D-641.