This repository has been archived by the owner on May 19, 2024. It is now read-only.
[WEAV-152] 미팅 팀 도메인 구현 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dojinyou
reviewed
Feb 3, 2024
domain/src/main/kotlin/com/studentcenter/weave/domain/meeting/vo/Location.kt
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,9 @@ | |||
| package com.studentcenter.weave.domain.meeting.enums | |||
|
|
|||
| enum class TeamType( | |||
There was a problem hiding this comment.
p3) 이부분은 팀 타입보다 멤버의 수? 같은 개념이 더 직관적인 것 같은데 어떠세요?
There was a problem hiding this comment.
음 이건 피그마 상으로
이런식으로 멤버수보다는 미팅 종류가 정해져있어서, 멤버수로하면 오히려 더 모호할것 같더라구요.
숫자로하면 1명도 되나? 5명도 되나? 이렇게 고민 될거같아서
There was a problem hiding this comment.
음, 피그마 상으로 그런데 정책적으로 필요하면 숫자는 제한하면 될 것 같구요!
화면은 바뀔 수 있는거니까 개념적으로 접근하는게 좋다고 생각했어요!
만약에, 3:3이 3명이라는 표현으로 바뀐다고 저희 내부적인 enum 타입이 변경되면 안될 것 같아서요!
dojinyou
approved these changes
Feb 3, 2024
domain/src/main/kotlin/com/studentcenter/weave/domain/meeting/enums/Location.kt
Outdated
Show resolved
Hide resolved
…enums/Location.kt Co-authored-by: 유도진 <[email protected]>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현사항
미팅팀 도메인 구현
이슈