Skip to content
This repository has been archived by the owner on May 19, 2024. It is now read-only.

[WEAV-119] 회원 유스케이스 테스트 리펙터링 #37

Merged
merged 1 commit into from
Jan 30, 2024
Merged

[WEAV-119] 회원 유스케이스 테스트 리펙터링 #37

merged 1 commit into from
Jan 30, 2024

Conversation

waterfogSW
Copy link
Member

구현내용

  • Stub 사용을 줄이는 방향으로 리팩토링했어요,
  • OpenIdTokenResolveStrategyFactory의 경우 Application Context를 의존하고 있어서 별도 인터페이스를 통해 Stub을 만들었어요
  • context에 arrange, act넣기
    • 앞서 언급해주신 context 에 arrange act를 넣어 봤는데, 들여쓰기 간격이 생겨서 가독성이 좋지않은것 같아 일단 유지했어요

@waterfogSW waterfogSW added the refactor Refactoring code label Jan 30, 2024
@waterfogSW waterfogSW requested a review from dojinyou as a code owner January 30, 2024 13:13
@waterfogSW waterfogSW changed the title [WEAV-119] 테스트 리펙터링 [WEAV-119] 회원 유스케이스 테스트 리펙터링 Jan 30, 2024
@waterfogSW waterfogSW enabled auto-merge (squash) January 30, 2024 14:28
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@waterfogSW waterfogSW merged commit 5640954 into main Jan 30, 2024
3 checks passed
@waterfogSW waterfogSW deleted the feat/WEAV-119 branch January 30, 2024 14:32
@waterfogSW waterfogSW self-assigned this Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dojinyou dojinyou dojinyou approved these changes

Assignees

@waterfogSW waterfogSW

Labels
refactor Refactoring code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waterfogSW @dojinyou