This repository has been archived by the owner on May 19, 2024. It is now read-only.
[WEAV-340] 제안하기 API 개발 #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waterfogSW
commented
Apr 22, 2024
|
|
||
| override fun createSuggestion(request: SuggestionCreateRequest) { | ||
| request | ||
| .toCommand(getCurrentUserAuthentication()) |
There was a problem hiding this comment.
추후 getCurrentAuthentication 제거 리펙터링, argument resolver에 의해 controller에 직접 userAuthentication 매핑되도록 변경 예정 (타도메인도 마찬가지)
dojinyou
reviewed
Apr 22, 2024
...ain/kotlin/com/studentcenter/weave/application/suggestion/service/CreateSuggestionService.kt
Outdated
Show resolved
Hide resolved
...ain/kotlin/com/studentcenter/weave/application/suggestion/service/CreateSuggestionService.kt
Show resolved
Hide resolved
|
dojinyou
approved these changes
Apr 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
배경
설계