This repository has been archived by the owner on May 19, 2024. It is now read-only.
[WEAV-333] 사전 예약자 실 2배 지급 기능 구현 #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dojinyou
approved these changes
Apr 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
사전 예약자의 경우 실 2배 지급가능하도록 구현해뒀어요. 배포후 테이블 생성되면 예약자 이메일은 수동으로 기입할 예정입니다.
VerifyUniversityVerificationNumberTest.kt테스트 리팩터링이 필요할것 같아요, 다른 application service에 의존적인 부분이 있네요 (우선 최대한 기존 테스트 형태 유지 하면서 기능 구현해뒀어요)