Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: create home recommend data #147

Merged
merged 6 commits into from
Jan 22, 2024
Merged

Feat: create home recommend data #147

merged 6 commits into from
Jan 22, 2024

Conversation

Yamyam-code
Copy link
Member

@Yamyam-code Yamyam-code commented Jan 21, 2024 •
edited
Loading

개요

홈페이지 더미데이터를 pm분들이 제공하신 데이터를 바탕으로 생성
close #137

스크린샷

캡처

주요 내용

  • 홈페이지 더미데이터를 pm분들이 제공하신 데이터를 바탕으로 생성
  • 검색 로직 대대적인 변경
  • 임시 api 연결 (변경소지 다분)

고민한 점, 질문거리

  • 검색 로직 완전히 완성되면 은영님 버튼 연결할게요

@Yamyam-code Yamyam-code linked an issue Jan 21, 2024 that may be closed by this pull request
Feat: create home recommend data #137
Closed
1 task
@vercel Vercel
Copy link

vercel bot commented Jan 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
trip-vote-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2024 7:58pm

@Yamyam-code Yamyam-code self-assigned this Jan 21, 2024
@Yamyam-code Yamyam-code added this to the TripVote FE development milestone Jan 21, 2024
SKY-PEY
SKY-PEY approved these changes Jan 21, 2024
View reviewed changes
Copy link
Contributor

@SKY-PEY SKY-PEY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생많으셨습니다! 저 작성한 버튼에 들어간 함수는 지금 수정중인데 제 pr전에 연결하게 된다면 무시해주셔도 좋습니다ㅜ

@Yamyam-code Yamyam-code merged commit 0582c5e into dev Jan 22, 2024
3 checks passed
@Yamyam-code Yamyam-code deleted the 137-feat-create-home-recommend-data branch January 22, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SKY-PEY SKY-PEY SKY-PEY approved these changes

@HOOOO98 HOOOO98 HOOOO98 approved these changes

@NamgungJongMin NamgungJongMin NamgungJongMin approved these changes

@JeongMin83 JeongMin83 Awaiting requested review from JeongMin83

@JSH99 JSH99 Awaiting requested review from JSH99

Assignees

@Yamyam-code Yamyam-code

Labels
feat
Projects
FE Project
Status: Todo
Milestone
TripVote FE development
Development

Successfully merging this pull request may close these issues.

Feat: create home recommend data
4 participants
@Yamyam-code @NamgungJongMin @HOOOO98 @SKY-PEY