Adds builder and runner docker image. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavogel
reviewed
Jan 23, 2019
There was a problem hiding this comment.
f2f: I was referring to this So people using the runner would have to write a small healtchCheck.js script.. Confirmed we will put this in the runner itself.
See: https://www.flowdock.com/app/stocard/backend/messages/2591615
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two now docker images:
node:xx-builderimage, which is essentially the same as thenode:xximage, just with a better namingnode:xx-runnerimage, which does not have any additional installed software, except fortini. This reduces attack vector and size of the docker image.