-
-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Pinyin transliteration to Chinese sky culture #867
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a lot of work, thank you. I cannot discuss correct spelling with you, so I must assume this is correct. It is only a data change, so I approve.
However, it reminds me of the fact that we must deal with skyculture and language issues sooner or later. (Rather later in 2020.) The number of translatable strings is exploding, and this is a case for untranslatable strings. Or would Pinyin transliterations be translated/translitered again to other scripts systems?
Pinyin wikipedia It should be difficult to transliterate into other languages again, and seem to be treated as untranslatable strings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added Pinyin data should be untranslatable here, but we do not support this scheme in planetarium at the moment. Seems this is new one good point for catch into the specification of second edition of skycultures (and unification of course).
I know, it may be not very good from developers side, but this is very good for translators side - could you add comments for translators for Pinyin strings?
Added Pinyin transliteration to Chinese sky culture.