Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CN_SC fix #1449

Closed
wants to merge 2 commits into from
Closed

CN_SC fix #1449

wants to merge 2 commits into from

Conversation

ultrapre
Copy link
Contributor

@ultrapre ultrapre commented Dec 31, 2020 •
edited
Loading

Those unused 0 values should be removed. They also caused bugs cross platforms (crash).

@github-actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching skycultures/**:

  • Did you remember to update po/stellarium-skycultures/POFILES.in and src/translations.h files respectively to changes in sky cultures?
  • Did you remember to define classification parameter in sky cultures?

This is an automatically generated QA checklist based on modified files

@silas1037 silas1037 mentioned this pull request Dec 31, 2020
Closed
@alex-w
Copy link
Member

alex-w commented Dec 31, 2020

Those unused 0 values should be removed.

If you want delete them, then why you propose partial solution?

They also caused bugs cross platforms (crash).

windows, Mac, linux, bsd... haven't problems for those "unused" constellations. Why android have it?

@ultrapre
Copy link
Contributor Author

ultrapre commented Dec 31, 2020 •
edited
Loading

Maybe I need more time to debug and find why. In fact, removing those lines also follows the logic because no stars inside.

@ultrapre
Copy link
Contributor Author

Ummm, maybe it is a bad PR.

@ultrapre ultrapre closed this Dec 31, 2020
@alex-w alex-w added the purpose: cultural astronomy Issues, pull requests and proposals with cultural astronomy purposes label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-w alex-w Awaiting requested review from alex-w

@gzotti gzotti Awaiting requested review from gzotti

Assignees

@ultrapre ultrapre

Labels
purpose: cultural astronomy Issues, pull requests and proposals with cultural astronomy purposes
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ultrapre @alex-w