Skip to content

Commit

Permalink
Tentative fix for #651
Browse files Browse the repository at this point in the history
+ Force oculars popup to appear on Windows.
- Note however it comes with title bar and ignores night mode.
  • Loading branch information
gzotti committed Mar 14, 2019
1 parent a47f443 commit 4237aaf
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions plugins/Oculars/src/Oculars.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1265,6 +1265,9 @@ void Oculars::displayPopupMenu()
}
}

#if QT_VERSION >= 0x050700 && defined(Q_OS_WIN)
popup->showTearOffMenu(QCursor::pos());
#endif
popup->exec(QCursor::pos());
delete popup;
}
Expand Down

2 comments on commit 4237aaf

@alex-w
Copy link
Member

@alex-w alex-w commented on 4237aaf Mar 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm ... the problem is still here (in full window mode) and the patch introduce new one problem. Seems the popup menu in full window mode is opened under the main window (double buffering issue for OpenGL context on Windows?).

@gzotti
Copy link
Member Author

@gzotti gzotti commented on 4237aaf Mar 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can clearly see the popup on top of the main window. Win10, Qt5.12, Geforce 960M, Driver 411.63. Qt version or driver issue? If this does not work in general, I don't know what to do. I must admit I have never used this popup menu which seems to predate the top-right GUI menu.

Please sign in to comment.