Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] skip trigger analyze when table not update #52203

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

Youngwb
Copy link
Contributor

@Youngwb Youngwb commented Oct 22, 2024

Why I'm doing:

We support trigger analyze when query connector table in #50747, but it only would analyze all partitions when the task run, we could skip unchanged partitions analyze task.

What I'm doing:

  1. when run analyze task, skip analyze when table not changed
  2. skip analyze unchanged partitions
  3. modify the connector_table_query_trigger_analyze_small_table_interval and connector_table_query_trigger_analyze_large_table_interval default value, because we could skip useless analyze task, reduce the analyze interval
    Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@Youngwb Youngwb requested review from a team as code owners October 22, 2024 09:12
Copy link

sonarcloud bot commented Oct 22, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 41 / 41 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/statistics/ConnectorAnalyzeTask.java 33 33 100.00% []
🔵 com/starrocks/common/Config.java 2 2 100.00% []
🔵 com/starrocks/statistic/StatisticUtils.java 5 5 100.00% []
🔵 com/starrocks/statistic/StatisticsCollectJobFactory.java 1 1 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@Youngwb Youngwb merged commit f15a530 into StarRocks:main Oct 23, 2024
50 of 51 checks passed
@Youngwb Youngwb deleted the opt_trigger_analyze branch October 23, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants