Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix jdbc catalog change password not effect #51748

Merged
merged 1 commit into from
Oct 11, 2024
Merged

[BugFix] Fix jdbc catalog change password not effect #51748

merged 1 commit into from
Oct 11, 2024

Conversation

Smith-Cruise
Copy link
Contributor

@Smith-Cruise Smith-Cruise commented Oct 11, 2024 •
edited
Loading

Why I'm doing:

User changes the password will still use the original jdbc connection.

What I'm doing:

Change cache key compute logic.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

❌ fail : 0 / 3 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/jdbcbridge/JDBCScanner.java 0 3 00.00% [63, 65, 120]

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@dirtysalt dirtysalt enabled auto-merge (squash) October 11, 2024 05:01
@dirtysalt dirtysalt merged commit acce535 into StarRocks:main Oct 11, 2024
51 of 52 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Oct 11, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 11, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 11, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 11, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 11, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 11, 2024 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 11, 2024
@Smith-Cruise @mergify
[BugFix] Fix jdbc catalog change password not effect (#51748)
7658d21 
Signed-off-by: Smith Cruise <[email protected]>
(cherry picked from commit acce535)
@mergify mergify bot mentioned this pull request Oct 11, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Oct 11, 2024
@Smith-Cruise @mergify
[BugFix] Fix jdbc catalog change password not effect (#51748)
06c7a9c 
Signed-off-by: Smith Cruise <[email protected]>
(cherry picked from commit acce535)

# Conflicts:
#	java-extensions/jdbc-bridge/src/main/java/com/starrocks/jdbcbridge/JDBCScanner.java
@mergify mergify bot mentioned this pull request Oct 11, 2024
Closed
42 tasks
mergify bot pushed a commit that referenced this pull request Oct 11, 2024
@Smith-Cruise @mergify
[BugFix] Fix jdbc catalog change password not effect (#51748)
b9637b4 
Signed-off-by: Smith Cruise <[email protected]>
(cherry picked from commit acce535)

# Conflicts:
#	java-extensions/jdbc-bridge/src/main/java/com/starrocks/jdbcbridge/JDBCScanner.java
@mergify mergify bot mentioned this pull request Oct 11, 2024
Closed
42 tasks
mergify bot pushed a commit that referenced this pull request Oct 11, 2024
@Smith-Cruise @mergify
[BugFix] Fix jdbc catalog change password not effect (#51748)
4d55f1c 
Signed-off-by: Smith Cruise <[email protected]>
(cherry picked from commit acce535)

# Conflicts:
#	java-extensions/jdbc-bridge/src/main/java/com/starrocks/jdbcbridge/JDBCScanner.java
@mergify mergify bot mentioned this pull request Oct 11, 2024
Closed
42 tasks
mergify bot pushed a commit that referenced this pull request Oct 11, 2024
@Smith-Cruise @mergify
[BugFix] Fix jdbc catalog change password not effect (#51748)
930e81e 
Signed-off-by: Smith Cruise <[email protected]>
(cherry picked from commit acce535)

# Conflicts:
#	java-extensions/jdbc-bridge/src/main/java/com/starrocks/jdbcbridge/JDBCScanner.java
@mergify mergify bot mentioned this pull request Oct 11, 2024
Closed
42 tasks
@Smith-Cruise Smith-Cruise deleted the fix-jdbc-cache branch October 11, 2024 05:05
@Smith-Cruise Smith-Cruise mentioned this pull request Oct 11, 2024
Merged
24 tasks
stephen-shelby pushed a commit that referenced this pull request Oct 11, 2024
@Smith-Cruise
[BugFix] Fix jdbc catalog change password not effect (backport #51748) (
67cfd77 
#51765)

Signed-off-by: Smith Cruise <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 11, 2024
@mergify @Smith-Cruise
[BugFix] Fix jdbc catalog change password not effect (backport #51748) (
62020cb 
#51758)

Co-authored-by: Smith Cruise <[email protected]>
mergify bot pushed a commit that referenced this pull request Oct 11, 2024
@Smith-Cruise @mergify
[BugFix] Fix jdbc catalog change password not effect (backport #51748) (
68d04d5 
#51765)

Signed-off-by: Smith Cruise <[email protected]>
(cherry picked from commit 67cfd77)
@mergify mergify bot mentioned this pull request Oct 11, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Oct 11, 2024
@Smith-Cruise @mergify
[BugFix] Fix jdbc catalog change password not effect (backport #51748) (
5d0cdeb 
#51765)

Signed-off-by: Smith Cruise <[email protected]>
(cherry picked from commit 67cfd77)
@mergify mergify bot mentioned this pull request Oct 11, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Oct 11, 2024
@mergify @Smith-Cruise
[BugFix] Fix jdbc catalog change password not effect (backport #51748)…
2efde40 
… (backport #51765) (#51775)

Co-authored-by: Smith Cruise <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 11, 2024
@mergify @Smith-Cruise
[BugFix] Fix jdbc catalog change password not effect (backport #51748)…
2f40172 
… (backport #51765) (#51774)

Co-authored-by: Smith Cruise <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirtysalt dirtysalt dirtysalt approved these changes

@silverbullet233 silverbullet233 silverbullet233 approved these changes

@zombee0 zombee0 zombee0 approved these changes

Assignees

@Smith-Cruise Smith-Cruise

Labels
3.0 3.1 3.2-merged 3.2 3.3-merged 3.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Smith-Cruise @dirtysalt @silverbullet233 @zombee0