-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Fix the mem leak of VectorizedFunctionCallExpr #44275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdpain
approved these changes
Apr 17, 2024
Seaven
approved these changes
Apr 17, 2024
@Mergifyio rebase |
✅ Branch has been successfully rebased |
https://github.com/Mergifyio rebase |
Signed-off-by: trueeyu <[email protected]>
✅ Branch has been successfully rebased |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 1 / 1 (100.00%) file detail
|
andyziye
approved these changes
Apr 18, 2024
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
@Mergifyio backport branch-3.1 |
@Mergifyio backport branch-3.0 |
@Mergifyio backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
Signed-off-by: trueeyu <[email protected]> (cherry picked from commit e406099)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
Signed-off-by: trueeyu <[email protected]> (cherry picked from commit e406099)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
Signed-off-by: trueeyu <[email protected]> (cherry picked from commit e406099)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
Signed-off-by: trueeyu <[email protected]> (cherry picked from commit e406099)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
Signed-off-by: trueeyu <[email protected]> (cherry picked from commit e406099) # Conflicts: # be/src/exprs/function_call_expr.cpp # be/test/exprs/vectorized/function_call_expr_test.cpp
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Apr 18, 2024
) (#44363) Co-authored-by: trueeyu <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Apr 18, 2024
) (#44364) Co-authored-by: trueeyu <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Apr 18, 2024
) (#44365) Co-authored-by: trueeyu <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Apr 18, 2024
) (#44367) Signed-off-by: trueeyu <[email protected]> Co-authored-by: trueeyu <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Apr 18, 2024
) (#44366) Co-authored-by: trueeyu <[email protected]>
leiyang0324
pushed a commit
to leiyang0324/starrocks
that referenced
this pull request
Apr 19, 2024
) Signed-off-by: trueeyu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
This bug was introduced by #43838
The default value of
_fn_context_index
is -1, if open success, the value should be >=0.So this is no chance to call close if
_fn_context_index=0
, the mem leak will happend.All functions using prepare/close will leak memory.
What I'm doing:
Fixes https://github.com/StarRocks/StarRocksTest/issues/7088
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: