Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix potential thread safe issue about pindex major compact #44238

Merged
merged 1 commit into from
Apr 17, 2024
Merged

[BugFix] fix potential thread safe issue about pindex major compact #44238

merged 1 commit into from
Apr 17, 2024

Conversation

luohaha
Copy link
Contributor

@luohaha luohaha commented Apr 17, 2024

Why I'm doing:

major compact thread will access _fs concurrently with apply thread, it's not thread safe here.

What I'm doing:

fix it.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@luohaha luohaha requested a review from a team as a code owner April 17, 2024 07:25
@luohaha luohaha enabled auto-merge (squash) April 17, 2024 08:14
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/persistent_index.cpp 2 2 100.00% []

@luohaha luohaha merged commit 8fecf68 into StarRocks:main Apr 17, 2024
50 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Apr 17, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Apr 17, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 17, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Apr 17, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 17, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 17, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 17, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 17, 2024 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 17, 2024
@luohaha @mergify
[BugFix] fix potential thread safe issue about pindex major compact (#…
f246598 
…44238)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 8fecf68)
@mergify mergify bot mentioned this pull request Apr 17, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Apr 17, 2024
@luohaha @mergify
[BugFix] fix potential thread safe issue about pindex major compact (#…
4656e7b 
…44238)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 8fecf68)
@mergify mergify bot mentioned this pull request Apr 17, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Apr 17, 2024
@luohaha @mergify
[BugFix] fix potential thread safe issue about pindex major compact (#…
16c0b25 
…44238)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 8fecf68)

# Conflicts:
#	be/src/storage/persistent_index.cpp
@mergify mergify bot mentioned this pull request Apr 17, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Apr 17, 2024
@luohaha @mergify
[BugFix] fix potential thread safe issue about pindex major compact (#…
bcb4824 
…44238)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 8fecf68)

# Conflicts:
#	be/src/storage/persistent_index.cpp
@mergify mergify bot mentioned this pull request Apr 17, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Apr 17, 2024
@luohaha @mergify
[BugFix] fix potential thread safe issue about pindex major compact (#…
3174234 
…44238)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 8fecf68)

# Conflicts:
#	be/src/storage/persistent_index.cpp
@mergify mergify bot mentioned this pull request Apr 17, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Apr 17, 2024
@mergify @luohaha
[BugFix] fix potential thread safe issue about pindex major compact (…
0c06352 
…backport #44238) (#44262)

Co-authored-by: Yixin Luo <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Apr 17, 2024
@mergify @luohaha
[BugFix] fix potential thread safe issue about pindex major compact (…
7b4a448 
…backport #44238) (#44261)

Co-authored-by: Yixin Luo <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Apr 17, 2024
@mergify @luohaha
[BugFix] fix potential thread safe issue about pindex major compact (…
d4210ee 
…backport #44238) (#44263)

Signed-off-by: Yixin Luo <[email protected]>
Co-authored-by: Yixin Luo <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Apr 17, 2024
@mergify @luohaha
[BugFix] fix potential thread safe issue about pindex major compact (…
44c17f8 
…backport #44238) (#44264)

Signed-off-by: Yixin Luo <[email protected]>
Co-authored-by: Yixin Luo <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Apr 17, 2024
@mergify @luohaha
[BugFix] fix potential thread safe issue about pindex major compact (…
0746244 
…backport #44238) (#44265)

Signed-off-by: Yixin Luo <[email protected]>
Co-authored-by: Yixin Luo <[email protected]>
leiyang0324 pushed a commit to leiyang0324/starrocks that referenced this pull request Apr 19, 2024
@luohaha @leiyang0324
[BugFix] fix potential thread safe issue about pindex major compact (S…
33d2509 
…tarRocks#44238)

Signed-off-by: luohaha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

@sevev sevev sevev approved these changes

Assignees

@luohaha luohaha

Labels
2.5-merged 3.0-merged 3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luohaha @wyb @sevev