Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] to avoid s3:// not supported case #42369

Merged
merged 2 commits into from
Mar 12, 2024
Merged

[Enhancement] to avoid s3:// not supported case #42369

merged 2 commits into from
Mar 12, 2024

Conversation

dirtysalt
Copy link
Contributor

@dirtysalt dirtysalt commented Mar 9, 2024 •
edited
Loading

Why I'm doing:

Some user create database s3 glue catalog reports

Unexpected exception: Got exception: org.apache.hadoop.fs.UnsupportedFileSystemException No FileSystem for scheme "s3"

Some user hit same problem when access HURI MOR table

Failed to open the off-heap table scanner. java exception details: java.io.IOException: Failed to open the hudi MOR slice reader.
	at com.starrocks.hudi.reader.HudiSliceScanner.open(HudiSliceScanner.java:219)
Caused by: org.apache.hadoop.fs.UnsupportedFileSystemException: No FileSystem for scheme "s3"

What I'm doing:

I think we can make s3 scheme maps to org.apache.hadoop.fs.s3a.S3AFileSystem by default.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

Smith-Cruise
Smith-Cruise reviewed Mar 9, 2024
View reviewed changes
conf/core-site.xml
@@ -0,0 +1,6 @@
<configuration>
<property>
<name>fs.s3.impl</name>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mapping s3a also

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to map s3a, s3a is already builtin mapped.

https://hadoop.apache.org/docs/current/hadoop-aws/tools/hadoop-aws/index.html

stephen-shelby
stephen-shelby previously approved these changes Mar 11, 2024
View reviewed changes
@dirtysalt
fix be install
fbb7a00 
Signed-off-by: yanz <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@dirtysalt dirtysalt enabled auto-merge (squash) March 12, 2024 01:09
@dirtysalt dirtysalt merged commit 8956689 into StarRocks:main Mar 12, 2024
44 of 45 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Mar 12, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Mar 12, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 12, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 12, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 12, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 12, 2024 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 12, 2024
@dirtysalt @mergify
[Enhancement] to avoid s3:// not supported case (#42369)
b282929 
Signed-off-by: yanz <[email protected]>
(cherry picked from commit 8956689)
mergify bot pushed a commit that referenced this pull request Mar 12, 2024
@dirtysalt @mergify
[Enhancement] to avoid s3:// not supported case (#42369)
1208ce7 
Signed-off-by: yanz <[email protected]>
(cherry picked from commit 8956689)

# Conflicts:
#	be/CMakeLists.txt
#	build.sh
mergify bot pushed a commit that referenced this pull request Mar 12, 2024
@dirtysalt @mergify
[Enhancement] to avoid s3:// not supported case (#42369)
68d978a 
Signed-off-by: yanz <[email protected]>
(cherry picked from commit 8956689)

# Conflicts:
#	be/CMakeLists.txt
This was referenced Mar 12, 2024
Merged
Merged
Merged
mergify bot pushed a commit that referenced this pull request Mar 12, 2024
@dirtysalt @mergify
[Enhancement] to avoid s3:// not supported case (#42369)
74d4587 
Signed-off-by: yanz <[email protected]>
(cherry picked from commit 8956689)

# Conflicts:
#	be/CMakeLists.txt
#	build.sh
@mergify mergify bot mentioned this pull request Mar 12, 2024
Merged
18 tasks
wanpengfei-git pushed a commit that referenced this pull request Mar 12, 2024
@mergify @dirtysalt
[Enhancement] to avoid s3:// not supported case (backport #42369) (#…
2022c52 
…42457)

Co-authored-by: dirtysalt <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Mar 12, 2024
@mergify @dirtysalt
[Enhancement] to avoid s3:// not supported case (backport #42369) (#…
fde6cee 
…42458)

Signed-off-by: yanz <[email protected]>
Co-authored-by: dirtysalt <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Mar 12, 2024
@mergify @dirtysalt
[Enhancement] to avoid s3:// not supported case (backport #42369) (#…
ab982a8 
…42459)

Signed-off-by: yanz <[email protected]>
Co-authored-by: dirtysalt <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Mar 12, 2024
@mergify @dirtysalt
[Enhancement] to avoid s3:// not supported case (backport #42369) (#…
b36fe6a 
…42460)

Signed-off-by: yanz <[email protected]>
Co-authored-by: dirtysalt <[email protected]>
@dirtysalt dirtysalt deleted the fix-s3-scheme-case branch March 12, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smith-Cruise Smith-Cruise Smith-Cruise approved these changes

@chaoyli chaoyli chaoyli approved these changes

@murphyatwork murphyatwork murphyatwork approved these changes

@stephen-shelby stephen-shelby stephen-shelby left review comments

Assignees

@dirtysalt dirtysalt

Labels
2.5-merged 3.0-merged 3.1-merged 3.2-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dirtysalt @Smith-Cruise @chaoyli @stephen-shelby @murphyatwork