-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] refactor hdfs scanner apppend_or_update column #42248
Conversation
Signed-off-by: yanz <[email protected]>
2f0117e
to
9f29c42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left LGTM
} | ||
ck->set_num_rows(row_count); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not necessarily, but I guess there is no harm to do that.
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 19 / 20 (95.00%) file detail
|
@mergify backport branch-3.2 |
@mergify backport branch-3.1 |
✅ Backports have been created
|
✅ Backports have been created
|
@mergify backport branch-3.0 |
@mergify backport branch-2.5 |
✅ Backports have been created
|
✅ Backports have been created
|
Signed-off-by: yanz <[email protected]> (cherry picked from commit c7f5207)
Signed-off-by: yanz <[email protected]> (cherry picked from commit c7f5207) # Conflicts: # be/src/column/chunk.h # be/src/exec/hdfs_scanner.cpp # be/src/exec/hdfs_scanner.h # be/src/exec/hdfs_scanner_orc.cpp # be/src/exec/jni_scanner.cpp # be/src/formats/parquet/file_reader.cpp
Signed-off-by: yanz <[email protected]> (cherry picked from commit c7f5207) # Conflicts: # be/src/column/chunk.h # be/src/exec/hdfs_scanner.cpp # be/src/exec/hdfs_scanner.h # be/src/exec/hdfs_scanner_orc.cpp # be/src/exec/jni_scanner.cpp # be/src/formats/parquet/file_reader.cpp
Signed-off-by: yanz <[email protected]> (cherry picked from commit c7f5207) # Conflicts: # be/src/column/chunk.h # be/src/exec/jni_scanner.cpp # be/src/exec/vectorized/hdfs_scanner.cpp # be/src/exec/vectorized/hdfs_scanner.h # be/src/exec/vectorized/hdfs_scanner_orc.cpp # be/src/formats/parquet/file_reader.cpp
…42248) (#42365) Co-authored-by: dirtysalt <[email protected]> Co-authored-by: Smith Cruise <[email protected]>
…42248) (#42367) Signed-off-by: yanz <[email protected]> Co-authored-by: dirtysalt <[email protected]> Co-authored-by: Smith Cruise <[email protected]>
Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: