Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] refactor hdfs scanner apppend_or_update column #42248

Merged
merged 1 commit into from
Mar 8, 2024
Merged

[Refactor] refactor hdfs scanner apppend_or_update column #42248

merged 1 commit into from
Mar 8, 2024

Conversation

dirtysalt
Copy link
Contributor

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@dirtysalt dirtysalt requested review from a team as code owners March 7, 2024 03:58
@dirtysalt dirtysalt changed the title [refactor] refactor hdfs scanner apppend_or_update column [Refactor] refactor hdfs scanner apppend_or_update column Mar 7, 2024
zombee0
zombee0 reviewed Mar 8, 2024
View reviewed changes
Copy link
Contributor

@zombee0 zombee0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left LGTM

be/src/exec/hdfs_scanner.cpp
}
ck->set_num_rows(row_count);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessarily, but I guess there is no harm to do that.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

[BE Incremental Coverage Report]

✅ pass : 19 / 20 (95.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/jni_scanner.cpp 1 2 50.00% [386]
🔵 be/src/formats/parquet/file_reader.cpp 2 2 100.00% []
🔵 be/src/exec/hdfs_scanner_orc.cpp 1 1 100.00% []
🔵 be/src/exec/hdfs_scanner.cpp 8 8 100.00% []
🔵 be/src/column/chunk.cpp 7 7 100.00% []

@satanson satanson merged commit c7f5207 into StarRocks:main Mar 8, 2024
51 checks passed
@dirtysalt
Copy link
Contributor Author

@mergify backport branch-3.2

@dirtysalt
Copy link
Contributor Author

@mergify backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 8, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 8, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@dirtysalt
Copy link
Contributor Author

@mergify backport branch-3.0

@dirtysalt
Copy link
Contributor Author

@mergify backport branch-2.5

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 8, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 8, 2024 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 8, 2024
@dirtysalt @mergify
[Refactor] refactor hdfs scanner apppend_or_update column (#42248)
83fd10b 
Signed-off-by: yanz <[email protected]>
(cherry picked from commit c7f5207)
@mergify mergify bot mentioned this pull request Mar 8, 2024
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Mar 8, 2024
@dirtysalt @mergify
[Refactor] refactor hdfs scanner apppend_or_update column (#42248)
bae469e 
Signed-off-by: yanz <[email protected]>
(cherry picked from commit c7f5207)

# Conflicts:
#	be/src/column/chunk.h
#	be/src/exec/hdfs_scanner.cpp
#	be/src/exec/hdfs_scanner.h
#	be/src/exec/hdfs_scanner_orc.cpp
#	be/src/exec/jni_scanner.cpp
#	be/src/formats/parquet/file_reader.cpp
mergify bot pushed a commit that referenced this pull request Mar 8, 2024
@dirtysalt @mergify
[Refactor] refactor hdfs scanner apppend_or_update column (#42248)
46223d1 
Signed-off-by: yanz <[email protected]>
(cherry picked from commit c7f5207)

# Conflicts:
#	be/src/column/chunk.h
#	be/src/exec/hdfs_scanner.cpp
#	be/src/exec/hdfs_scanner.h
#	be/src/exec/hdfs_scanner_orc.cpp
#	be/src/exec/jni_scanner.cpp
#	be/src/formats/parquet/file_reader.cpp
This was referenced Mar 8, 2024
Closed
Merged
mergify bot pushed a commit that referenced this pull request Mar 8, 2024
@dirtysalt @mergify
[Refactor] refactor hdfs scanner apppend_or_update column (#42248)
dd8a23f 
Signed-off-by: yanz <[email protected]>
(cherry picked from commit c7f5207)

# Conflicts:
#	be/src/column/chunk.h
#	be/src/exec/jni_scanner.cpp
#	be/src/exec/vectorized/hdfs_scanner.cpp
#	be/src/exec/vectorized/hdfs_scanner.h
#	be/src/exec/vectorized/hdfs_scanner_orc.cpp
#	be/src/formats/parquet/file_reader.cpp
@mergify mergify bot mentioned this pull request Mar 8, 2024
Closed
18 tasks
@dirtysalt dirtysalt deleted the refactor-column branch March 9, 2024 04:03
@Smith-Cruise Smith-Cruise mentioned this pull request Mar 11, 2024
Merged
23 tasks
wanpengfei-git pushed a commit that referenced this pull request Mar 12, 2024
@mergify @dirtysalt @Smith-Cruise
[Refactor] refactor hdfs scanner apppend_or_update column (backport #…
e13f01e 
…42248) (#42365)

Co-authored-by: dirtysalt <[email protected]>
Co-authored-by: Smith Cruise <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Mar 12, 2024
@mergify @dirtysalt @Smith-Cruise
[Refactor] refactor hdfs scanner apppend_or_update column (backport #…
6106fe8 
…42248) (#42367)

Signed-off-by: yanz <[email protected]>
Co-authored-by: dirtysalt <[email protected]>
Co-authored-by: Smith Cruise <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zombee0 zombee0 zombee0 left review comments

@satanson satanson satanson approved these changes

@sduzh sduzh sduzh approved these changes

@letian-jiang letian-jiang letian-jiang approved these changes

Assignees

@dirtysalt dirtysalt

Labels
3.1-merged 3.2-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dirtysalt @satanson @sduzh @letian-jiang @zombee0