Skip to content

Commit

Permalink
[BugFix] Fix union isnullable error (#32426)
Browse files Browse the repository at this point in the history 
Signed-off-by: Seaven <[email protected]>
(cherry picked from commit c39da42)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/plan/PlanFragmentBuilder.java
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/EmptyValueTest.java
  • Loading branch information
@Seaven @mergify
Seaven authored and mergify[bot] committed Mar 14, 2024
1 parent c958128 commit 791c9bf
Show file tree
Hide file tree
Showing 2 changed files with 212 additions and 0 deletions.
15 changes: 15 additions & 0 deletions fe/fe-core/src/main/java/com/starrocks/sql/plan/PlanFragmentBuilder.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2518,9 +2518,24 @@ private PlanFragment buildSetOperation(OptExpression optExpr, ExecPlan context,

// reset column is nullable, for handle union select xx join select xxx...
setOperationNode.setHasNullableGenerateChild();
<<<<<<< HEAD
for (ColumnRefOperator columnRefOperator : setOperation.getOutputColumnRefOp()) {
SlotDescriptor slotDesc = context.getDescTbl().getSlotDesc(new SlotId(columnRefOperator.getId()));
slotDesc.setIsNullable(slotDesc.getIsNullable() | setOperationNode.isHasNullableGenerateChild());
=======
List<Expr> setOutputList = Lists.newArrayList();
for (int index = 0; index < setOperation.getOutputColumnRefOp().size(); index++) {
ColumnRefOperator columnRefOperator = setOperation.getOutputColumnRefOp().get(index);
SlotDescriptor slotDesc = context.getDescTbl().getSlotDesc(new SlotId(columnRefOperator.getId()));
boolean isNullable = slotDesc.getIsNullable() | setOperationNode.isHasNullableGenerateChild();
for (List<ColumnRefOperator> childOutputColumn : setOperation.getChildOutputColumns()) {
ColumnRefOperator childRef = childOutputColumn.get(index);
Expr childExpr = ScalarOperatorToExpr.buildExecExpression(childRef, formatterContext);
isNullable |= childExpr.isNullable();
}
slotDesc.setIsNullable(isNullable);
setOutputList.add(new SlotRef(String.valueOf(columnRefOperator.getId()), slotDesc));
>>>>>>> c39da426f6 ([BugFix] Fix union isnullable error (#32426))
}
setOperationTuple.computeMemLayout();

Expand Down
197 changes: 197 additions & 0 deletions fe/fe-core/src/test/java/com/starrocks/sql/plan/EmptyValueTest.java
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,197 @@
// Copyright 2021-present StarRocks, Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package com.starrocks.sql.plan;

import com.starrocks.common.FeConstants;
import org.junit.AfterClass;
import org.junit.BeforeClass;
import org.junit.Test;

public class EmptyValueTest extends PlanTestBase {
@BeforeClass
public static void beforeClass() throws Exception {
PlanTestBase.beforeClass();
FeConstants.enablePruneEmptyOutputScan = true;
FeConstants.runningUnitTest = true;
}

@AfterClass
public static void afterClass() {
FeConstants.enablePruneEmptyOutputScan = false;
PlanTestBase.afterClass();
}

@Test
public void testPartitionCrossJoin() throws Exception {
String sql = "select * from lineitem_partition p join t1 join t2 join t3 where L_SHIPDATE = '2000-01-01' ";
String plan = getFragmentPlan(sql);
assertContains(plan, "RESULT SINK\n" +
"\n" +
" 0:EMPTYSET");

sql = "select * from lineitem_partition p join t0 on p.L_ORDERKEY = t0.v2 where L_SHIPDATE = '2000-01-01' ";
plan = getFragmentPlan(sql);
assertContains(plan, "RESULT SINK\n" +
"\n" +
" 0:EMPTYSET");
}

@Test
public void testPartitionOtherJoin() throws Exception {
String sql = "select L_PARTKEY, t0.v2 from lineitem_partition p " +
"left outer join t0 on p.L_ORDERKEY = t0.v2 where L_SHIPDATE = '2000-01-01' ";
String plan = getFragmentPlan(sql);
assertContains(plan, "RESULT SINK\n" +
"\n 0:EMPTYSET");

sql = "select L_PARTKEY, t0.v2 from lineitem_partition p " +
"right outer join t0 on p.L_ORDERKEY = t0.v2 where L_SHIPDATE = '2000-01-01' ";
plan = getFragmentPlan(sql);
assertContains(plan, "RESULT SINK\n" +
"\n 0:EMPTYSET");

sql = "select L_PARTKEY, t0.v2 from t0 left outer join " +
"(select * from lineitem_partition p where L_SHIPDATE = '2000-01-01') x on x.L_ORDERKEY = t0.v2";
plan = getFragmentPlan(sql);
assertContains(plan, "1:Project\n" +
" | <slot 2> : 2: v2\n" +
" | <slot 5> : NULL\n" +
" | \n" +
" 0:OlapScanNode\n" +
" TABLE: t0");

sql = "select L_PARTKEY, t0.v2 from t0 right outer join " +
"(select * from lineitem_partition p where L_SHIPDATE = '2000-01-01') x on x.L_ORDERKEY = t0.v2";
plan = getFragmentPlan(sql);
assertContains(plan, "RESULT SINK\n" +
"\n 0:EMPTYSET");

sql = "select L_PARTKEY from lineitem_partition p " +
"left semi join t0 on p.L_ORDERKEY = t0.v2 where L_SHIPDATE = '2000-01-01' ";
plan = getFragmentPlan(sql);
assertContains(plan, "RESULT SINK\n" +
"\n 0:EMPTYSET");

sql = "select t0.v2 from t0 left semi join " +
"(select * from lineitem_partition p where L_SHIPDATE = '2000-01-01') x on x.L_ORDERKEY = t0.v2";
plan = getFragmentPlan(sql);
assertContains(plan, "RESULT SINK\n" +
"\n 0:EMPTYSET");

sql = "select L_PARTKEY from t0 right semi join " +
"(select * from lineitem_partition p where L_SHIPDATE = '2000-01-01') x on x.L_ORDERKEY = t0.v2";
plan = getFragmentPlan(sql);
assertContains(plan, "RESULT SINK\n" +
"\n 0:EMPTYSET");

sql = "select L_PARTKEY from lineitem_partition p " +
"left anti join t0 on p.L_ORDERKEY = t0.v2 where L_SHIPDATE = '2000-01-01' ";
plan = getFragmentPlan(sql);
assertContains(plan, "RESULT SINK\n" +
"\n 0:EMPTYSET");

sql = "select L_PARTKEY from t0 right anti join " +
"(select * from lineitem_partition p where L_SHIPDATE = '2000-01-01') x on x.L_ORDERKEY = t0.v2";
plan = getFragmentPlan(sql);
assertContains(plan, "RESULT SINK\n" +
"\n 0:EMPTYSET");

sql = "select t0.v2 from t0 left anti join " +
"(select * from lineitem_partition p where L_SHIPDATE = '2000-01-01') x on x.L_ORDERKEY = t0.v2";
plan = getFragmentPlan(sql);
assertContains(plan, " 0:OlapScanNode\n" +
" TABLE: t0");

sql = "select L_PARTKEY, t0.v2 from lineitem_partition p " +
"full outer join t0 on p.L_ORDERKEY = t0.v2 where L_SHIPDATE = '2000-01-01' ";
plan = getFragmentPlan(sql);
assertContains(plan, "RESULT SINK\n" +
"\n 0:EMPTYSET");

sql = "select L_PARTKEY, t0.v2 from t0 full outer join " +
"(select * from lineitem_partition p where L_SHIPDATE = '2000-01-01') x on x.L_ORDERKEY = t0.v2";
plan = getFragmentPlan(sql);
assertContains(plan, " 1:Project\n" +
" | <slot 2> : 2: v2\n" +
" | <slot 5> : NULL\n" +
" | \n" +
" 0:OlapScanNode\n" +
" TABLE: t0");
}

@Test
public void testAggregate() throws Exception {
String sql = "select sum(1) from lineitem_partition p where L_SHIPDATE = '2000-01-01' group by L_PARTKEY";
String plan = getFragmentPlan(sql);
assertContains(plan, "0:EMPTYSET");

sql = "select sum(L_PARTKEY) from lineitem_partition p where L_SHIPDATE = '2000-01-01' ";
plan = getFragmentPlan(sql);
assertContains(plan, "1:AGGREGATE (update finalize)\n" +
" | output: sum(2: L_PARTKEY)\n" +
" | group by: \n" +
" | \n" +
" 0:EMPTYSET");
}

@Test
public void testCTE() throws Exception {
String sql = "with x as (select * from lineitem_partition p where L_SHIPDATE = '2000-01-01')" +
"select * from " +
"x x1 join x x2 on x1.L_ORDERKEY = x2.L_ORDERKEY" +
" join x x3 on x1.L_ORDERKEY = x3.L_ORDERKEY" +
" join x x4 on x1.L_ORDERKEY = x4.L_ORDERKEY" +
" join x x5 on x1.L_ORDERKEY = x5.L_ORDERKEY";
String plan = getFragmentPlan(sql);
assertContains(plan, "0:EMPTYSET");

connectContext.getSessionVariable().setCboCTERuseRatio(-1);
plan = getFragmentPlan(sql);
connectContext.getSessionVariable().setCboCTERuseRatio(1.5);
assertContains(plan, "0:EMPTYSET");

connectContext.getSessionVariable().setCboCTERuseRatio(0);
plan = getFragmentPlan(sql);
connectContext.getSessionVariable().setCboCTERuseRatio(1.5);
assertContains(plan, "0:EMPTYSET");
}

@Test
public void testOther() throws Exception {
String sql = "select *, (select L_LINENUMBER from lineitem_partition p where L_SHIPDATE = '2000-01-01') x " +
"from t0;";
String plan = getFragmentPlan(sql);
assertContains(plan, " 2:ASSERT NUMBER OF ROWS\n" +
" | assert number of rows: LE 1\n" +
" | \n" +
" 1:EMPTYSET");
}

@Test
public void testUnionSlot() throws Exception {
String sql = "select L_ORDERKEY " +
"from t0 left outer join lineitem_partition on L_ORDERKEY = t0.v2 and L_SHIPDATE = '2000-01-01' " +
"union all " +
"select L_ORDERKEY " +
"from t0 left outer join lineitem_partition on L_ORDERKEY = t0.v2 and L_SHIPDATE = '2000-01-01' ";
String plan = getVerboseExplain(sql);
assertContains(plan, " 0:UNION\n" +
" | output exprs:\n" +
" | [41, INT, true]\n" +
" | child exprs:\n" +
" | [4: L_ORDERKEY, INT, true]\n" +
" | [24: L_ORDERKEY, INT, true]");
}
}

0 comments on commit 791c9bf

Please sign in to comment.