This repository has been archived by the owner on Jul 13, 2024. It is now read-only.
Phase02 clean code corrected #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RAAvenger
suggested changes
Nov 23, 2023
Comment on lines
13
to
18
| for (String word : words) { | ||
| Set<String> searchResult = WordFileNameFinder.searchWord(word, invertedIndex); | ||
| if(finalResult.isEmpty()){ | ||
| finalResult.addAll(searchResult); | ||
| } | ||
| else{ |
There was a problem hiding this comment.
method extracted
| e.printStackTrace(); | ||
| } | ||
| } else { | ||
| System.out.println("Specified path is not a directory."); |
There was a problem hiding this comment.
exception is used.
Comment on lines
31
to
59
| Map<String, Set<String>> invertedIndex = new HashMap<>(); | ||
|
|
||
| for (String fileName : fileNamesInFolder) { | ||
| try { | ||
| File file = new File(directoryPath + "/" + fileName); | ||
| Scanner myReader = new Scanner(file); | ||
|
|
||
| while (myReader.hasNextLine()) { | ||
| Set<String> documentIds = new HashSet<String>(); | ||
| documentIds.add(fileName); | ||
|
|
||
| String data = myReader.nextLine(); | ||
| String[] splittedData = data.split(" "); | ||
|
|
||
| for (String word : splittedData) { | ||
| // Ignoring empty words | ||
| if (word == "") { | ||
| continue; | ||
| } | ||
| // Inserting new entry to inverted index table | ||
| invertedIndex.computeIfAbsent(word, k -> new HashSet<>()).addAll(documentIds); | ||
| } | ||
| } | ||
| myReader.close(); | ||
| } catch (FileNotFoundException e) { | ||
| System.out.println("An error occurred."); | ||
| e.printStackTrace(); | ||
| } | ||
| } |
There was a problem hiding this comment.
class extracted.
Comment on lines
16
to
28
| // Getting directory path and user input | ||
| Scanner myScanner = new Scanner(System.in); | ||
|
|
||
| System.out.print("Enter Data Folder Path: "); | ||
| final String directoryPath = myScanner.nextLine(); | ||
|
|
||
| System.out.print("Enter Search Query: "); | ||
| final String userInput = myScanner.nextLine(); | ||
|
|
||
| myScanner.close(); | ||
|
|
||
| // Finding name of all files that are in EnglishData directory | ||
| ArrayList<String> fileNamesInFolder = FileReader.getFileNames(directoryPath); |
There was a problem hiding this comment.
method extracted.
Comment on lines
60
to
65
|
|
||
| // Categorizing command words into or_words, necessary and forbidden groups | ||
| ArrayList<String> necessaryWords = WordCategorizer.categorizer(userInput, ""); | ||
| ArrayList<String> orWords = WordCategorizer.categorizer(userInput, "+"); | ||
| ArrayList<String> notWords = WordCategorizer.categorizer(userInput, "-"); | ||
|
|
There was a problem hiding this comment.
method extracted.
| ArrayList<String> orWords = WordCategorizer.categorizer(userInput, "+"); | ||
| ArrayList<String> notWords = WordCategorizer.categorizer(userInput, "-"); | ||
|
|
||
| // Initializing some sets for forming final answer |
There was a problem hiding this comment.
class extracted.
|
|
||
| public class WordFileNameFinder { | ||
| // Searchs a word in inverted index then returns name of files that are containing that word | ||
| public static Set<String> searchWord(String word, Map<String, Set<String>> invertedIndex) { |
There was a problem hiding this comment.
invertedIndex should be a class
There was a problem hiding this comment.
now we have another class called InvertedIndexWordSearch.
…egorizer extracted in two classes.
RAAvenger
approved these changes
Dec 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
اصول SOLID و clean code روی فاز قبلی پروژه اعمال شدند.