Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Checkbox component #36

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Add Checkbox component #36

merged 1 commit into from
Jan 20, 2025

Conversation

arkadiuszbachorski
Copy link
Collaborator

Add Checkbox component

♻️ Current situation & Problem

Closes #15

⚙️ Release Notes

  • Add Checkbox component

image

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.19%. Comparing base (0fed267) to head (bff4f55).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   82.12%   82.19%   +0.08%     
==========================================
  Files         141      143       +2     
  Lines        2846     2863      +17     
  Branches      340      341       +1     
==========================================
+ Hits         2337     2353      +16     
- Misses        488      489       +1     
  Partials       21       21              
Files with missing lines Coverage Δ
src/components/Checkbox/Checkbox.tsx 100.00% <100.00%> (ø)
src/components/Checkbox/index.tsx 100.00% <100.00%> (ø)
src/index.ts 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fed267...bff4f55. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool; looks great and thank you for picking this up. Thank you for closing the other PR and closing the related issue to this once this is merged (#15, #19) 👍

@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Jan 20, 2025
@arkadiuszbachorski arkadiuszbachorski merged commit 0efe4ad into main Jan 20, 2025
9 checks passed
@arkadiuszbachorski arkadiuszbachorski deleted the arek/add-checkbox branch January 20, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add Checkbox component
2 participants