Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SideLabel positioning #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arkadiuszbachorski
Copy link
Collaborator

@arkadiuszbachorski arkadiuszbachorski commented Jan 14, 2025

Improve SideLabel positioning

♻️ Current situation & Problem

SideLabel needs to be versatile to handle all kind of input/label sizes, like bigger Checkbox or Switch.

⚙️ Release Notes

  • Add center prop
  • Remove margin and wrapper to rely on flex properties

image

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.13%. Comparing base (0fed267) to head (001c6d9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   82.12%   82.13%   +0.02%     
==========================================
  Files         141      141              
  Lines        2846     2848       +2     
  Branches      340      340              
==========================================
+ Hits         2337     2339       +2     
  Misses        488      488              
  Partials       21       21              
Files with missing lines Coverage Δ
src/components/SideLabel/SideLabel.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fed267...001c6d9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant