Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Execute Logic for Flexible HealthKit Query Execution #20

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

PSchmiedmayer
Copy link
Member

Improve Execute Logic for Flexible HealthKit Query Execution

♻️ Current situation & Problem

  • Executions that are performed after the initial configuration were never fully activated.

⚙️ Release Notes

  • Improves the execution of HealthKit queries.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@PSchmiedmayer PSchmiedmayer added the bug Something isn't working label Mar 11, 2024
@PSchmiedmayer PSchmiedmayer self-assigned this Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.16%. Comparing base (3562808) to head (54d4040).

❗ Current head 54d4040 differs from pull request most recent head 668a253. Consider uploading reports for the commit 668a253 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   68.90%   70.16%   +1.26%     
==========================================
  Files          11       11              
  Lines         463      459       -4     
==========================================
+ Hits          319      322       +3     
+ Misses        144      137       -7     
Files Coverage Δ
...hKit/CollectSample/HealthKitSampleDataSource.swift 93.43% <100.00%> (-0.16%) ⬇️
Sources/SpeziHealthKit/HealthKit.swift 84.89% <100.00%> (+8.14%) ⬆️
...hKit/HealthKitDataSource/HealthKitDataSource.swift 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3562808...668a253. Read the comment docs.

@PSchmiedmayer PSchmiedmayer merged commit 1e9cb5a into main Mar 11, 2024
6 checks passed
@PSchmiedmayer PSchmiedmayer deleted the fix/execute branch March 11, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant