generated from StanfordBDHG/SwiftPackageTemplate
-
-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Additional documents for CollectSample and HealthKitConstraint (#18)
# Additional documents for CollectSample and HealthKitConstraint ## ♻️ Current situation & Problem When working with this package for our PICS application, I found it a bit confusing about the `add` and `remove` functions in the `HealthKitConstraint` as I misunderstood them to be adding/removing health kit samples to/from the data sources instead of our application. Also, when using `CollectSample`, I spent some time finding how to filter the health kit query to collect data within the specific time range. I thought that this package did not support such filtering until I looked into the codes and realized that I could also input the predicate to it. I also found that the documentation mentioned the predicate initializations for `CollectSample` only after I found the predicate parameter in the codes, and would appreciate that if it could be mentioned more clearly. I think adding more documentation and code examples for clarification will possibly not benefit those who are familiar with Swift documentation or HealthKit packages, but might help users who are new to Swift to get on board with this package more easily. ## ⚙️ Release Notes - Added a code example including predicates for CollectSample - Clarify the add and remove functions for HealthKitConstraint ## 📚 Documentation Only additional documents were added were added in this PR. ## ✅ Testing Only additional documents were added and no codes were changed. Also checked and verified the changes in the documentation by building documentation locally. ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
- Loading branch information
Showing
5 changed files
with
46 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters