Add /opt/stackdriver/stack-config for backward compatibility. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuskens
suggested changes
Dec 20, 2018
| @@ -365,6 +367,9 @@ fi | |||
| %{_initddir}/stackdriver-agent | |||
| %config(noreplace) /etc/sysconfig/stackdriver | |||
|
|
|||
| # Backward compatibility. | |||
There was a problem hiding this comment.
Can you add instructions here and in stack-config about when the stack-config file and these two lines can be deleted (if ever)? Thanks.
There was a problem hiding this comment.
It may also be worthwhile to add comments in the other files for the stack-config lines.
There was a problem hiding this comment.
I don't believe it can ever be removed, unless we want to break the old installation commands (using stack-config --write-gcm, which are embedded in lots of systems at this point). But it's empty, so what's the harm?
|
Ping @rbuskens @qingling128 . |
|
@igorpeshansky do we need to resolve this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://repo.stackdriver.com/stack-install.sh