add resolution for entities package #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9b3475b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 tasks
owanturist
requested changes
Jan 22, 2025
There was a problem hiding this comment.
Hey @aalves08
Thank you for the proactive contribution to our codebase 🙇
The changes are fine by me, but I'd ask you to add changeset by following the link so I can approve the PR. Otherwise, if my commit is the last in the PR, I cannot approve it. Feel free to modify the content but keep in mind the file body will go to the release notes.
|
Done @owanturist 🙏 |
owanturist
added a commit
that referenced
this pull request
Jan 23, 2025
This reverts commit 0f190a2.
owanturist
added a commit
that referenced
this pull request
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rancher/dashboard#13175
Add resolution for
entitiespackage so that it satisfies the constraints verified with the update of Rancher Dashboard to VueJS 3.5 on rancher/dashboard#13085 as we can't fix this on the shell side for now because of a bug in yarn classic.