Removed st2web dependency on st2 module #279
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
nmaludy
force-pushed
the
hotfix/st2web-dependency
branch
from
9f5770c
to
66b0a7d
Compare
punkrokk
approved these changes
Dec 22, 2020
punkrokk
approved these changes
Dec 22, 2020
arm4b
suggested changes
Dec 22, 2020
pull-request-size
bot
added
size/S
arm4b
reviewed
Dec 23, 2020
| @@ -48,6 +48,7 @@ Below is the list of variables you can redefine in your playbook to customize st | |||
| | `st2_packs` | `[ st2 ]` | List of packs to install. This flag does not work with a `--python3` only pack. | |||
| | `st2_python_packages` | `[ ]` | List of python packages to install into the `/opt/stackstorm/st2` virtualenv. This is needed when deploying alternative auth or coordination backends which depend on Python modules to make them work. | |||
| | **st2web** | |||
| | `st2web_version` | `latest` | `st2web` version to install. `present` to install available package, `latest` to get automatic updates, or pin it to numeric version like `2.2.0`. | |||
There was a problem hiding this comment.
Can you please also list the st2web_revision var in the README as well? This looks like oversight from the past.
arm4b
reviewed
Dec 23, 2020
| @@ -10,3 +10,6 @@ st2web_ssl_certificate_key: null | |||
|
|
|||
| # String with a custom nginx configuration file to replace st2.conf. If not provided, the default st2.conf will be used. | |||
| st2web_nginx_config: null | |||
|
|
|||
| # StackStorm version to install. `present` to install available package, `latest` to get automatic updates or pin it to numeric version like `2.2.0`. | |||
| st2web_version: 'latest' | |||
There was a problem hiding this comment.
Please move the st2web_version variable added before the st2web_revision above to make them logically aligned as we have in other Ansible roles like st2 and st2chatops.
|
@nmaludy Could you please provide those minor changes and so we could merge the PR? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
StackStorm.st2webrole incorrectly declares a dependency on theStackStorm.st2module. This causes issues if trying to use these roles to only install individual components on a system. Example: if you only want to installnginxandst2webon a box, it also pulls inst2.