Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Type Annotations #198

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

kushal9897
Copy link

Pull Request Template

#180

Description

  • What changes are being made?

  • Why are these changes necessary?

  • Which issues or tickets does this PR close or relate to?

    • Related issue: #

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • [*] Other (please specify):

Checklist

  • [*] Code has been linted.
  • Documentation has been updated (if needed).
  • Tests have been added or updated (if needed).
  • Any breaking changes have been communicated to the team.

Screenshots or Recordings (if applicable)

Additional Information

Copy link
Member

@refeed refeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just have one comment for now

src/tirith/providers/sg_workflow/handler.py Outdated Show resolved Hide resolved
@kushal9897
Copy link
Author

kushal9897 commented Oct 22, 2024

@refeed, The requested change have been successfully implemented

Copy link
Member

@refeed refeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are tests failing, you need to import first the types before using it, e.g. from typing import List etc

https://github.com/StackGuardian/tirith/actions/runs/11470298982/job/31933623911?pr=198#step:5:733

@kushal9897
Copy link
Author

Thanks for pointing that out! I'll make sure to import the necessary types before using them. I'll fix the tests and update the code accordingly.

@kushal9897
Copy link
Author

@refeed I have fixed the error. Please review it.

Copy link

sonarcloud bot commented Nov 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants