Feature(IDE-1636): Scaffold StackAdapt action destination #1
Conversation
| '@if': { | ||
| exists: { '@path': '$.traits.email' }, | ||
| then: { '@path': '$.traits.email' }, | ||
| else: { '@path': '$.properties.email' } |
There was a problem hiding this comment.
For PII fields we fallback to trying to load them from properties when they are not present in traits - this is different from the destination function code that only took them from traits. Let me know if there's a particular reason to read from traits only.
| exports[`Testing snapshot for actions-stackadapt destination: forwardEvent action - all fields 1`] = `""`; | ||
|
|
||
| exports[`Testing snapshot for actions-stackadapt destination: forwardEvent action - required fields 1`] = `""`; |
There was a problem hiding this comment.
Does forwardActions have any required fields? The snapshot seems to be returning no data
There was a problem hiding this comment.
There is one required field - user_id (which can be derived from either user ID or anonymous ID)
The snapshot files are all auto-generated by Segment. The data in the snapshot file is the expected request body and we don't have one because we make GET requests with all data passed in the query string.
There was a problem hiding this comment.
gotcha makes sense. would it be worthwhile snapshotting the expected get request with data in query string for some of the event types we explicitly support in our CDP ? I'm thinking it'd double as documentation for downstream teams that want to understand how we map segment events (i.e. the ecommerce events were supporting in Shopify v1 can be cross referenced with what's supported in segment) back into pixel service calls or alternatively we can maintain a separate guide/doc to explain the mapping strategy for different event types?
There was a problem hiding this comment.
No issue with putting the expected query strings for the index.test.ts tests into a snapshot file, but I don't think the tests or any other files in this repo should be used for the purpose of documentation for our internal teams because it belongs to Segment and we will always need their permission to merge any changes upstream.
There was a problem hiding this comment.
On second thought I actually think it's safer to force developers to manually update the expected query params when they update the code rather than just regenerating a snapshot and hopefully reviewing it.
Why?
IDE-1636
We currently have a destination function developed for Segment users to forward Segment events to the StackAdapt pixel endpoint, enabling advertisers who are users of both Segment and StackAdapt to track conversions based on Segment events without needing to install a StackAdapt pixel on their website. We want to convert this destination function into an action destination in Segment's catalog so that Segment users can more easily discover it and can use it without needing to manage code.
What
Testing
Notes