-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: App Dashboard Facelift #163
base: dev
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for sporosdaoapp-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Based on https://www.figma.com/file/HjgPX0qjMYgvDjeliS4EwD/Sporos-DAO-App?node-id=552%3A84193 I've temporarily implemented What's the plan for mobile? Is the dashboard going to support a mobile view? I've added |
@sam-potter - the only thing here is that the MUI theme has been styled to work with with the design system. if we move to tailwind, most of that work would need to be redone. |
see: #162 |
@brightiron - what was the reason for choosing MUI? What parts of the DS have been implemented already? |
thats more of a question for @ivelin . they were already using it when i started helping with theming. and the request came through to create a mui theme on top of the design system. |
Hi folks. Sorry for the delay. I was submersed in devcon activities this week. Great time in Bogota. The choice of MUI was due to:
Happy to discuss switching to a different system after our MMP which is targeted for end of October. Hope that helps explain the rationale. |
@ivelin good to hear you enjoyed devcon. Heard great things about it from everyone. Your rationale for choosing MUI is perfectly understandable. In terms of this PR, I'll revert the |
#149