Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: App Dashboard Facelift #163

Draft
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

sam-potter
Copy link

@netlify
Copy link

netlify bot commented Oct 13, 2022

Deploy Preview for sporosdaoapp-dev ready!

Name Link
🔨 Latest commit fece58e
🔍 Latest deploy log https://app.netlify.com/sites/sporosdaoapp-dev/deploys/63478e044b4001000883c33d
😎 Deploy Preview https://deploy-preview-163--sporosdaoapp-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sam-potter
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@sam-potter sam-potter marked this pull request as draft October 13, 2022 04:05
@sam-potter
Copy link
Author

Based on https://www.figma.com/file/HjgPX0qjMYgvDjeliS4EwD/Sporos-DAO-App?node-id=552%3A84193

I've temporarily implemented @heroicons for their icons, lmk what the correct plan for icons is.

What's the plan for mobile? Is the dashboard going to support a mobile view?

I've added tailwindcss. I think using it should be permanent. Given that the DS is based off of Tailwind UI components, it basically means many of the components are already roughly built for us (will need minor tweaks) and we only need to piece them together.

@sam-potter
Copy link
Author

image

@brightiron
Copy link
Contributor

@sam-potter - the only thing here is that the MUI theme has been styled to work with with the design system. if we move to tailwind, most of that work would need to be redone.

@brightiron
Copy link
Contributor

see: #162

@sam-potter
Copy link
Author

@brightiron - what was the reason for choosing MUI? What parts of the DS have been implemented already?

@brightiron
Copy link
Contributor

brightiron commented Oct 13, 2022

@brightiron - what was the reason for choosing MUI? What parts of the DS have been implemented already?

thats more of a question for @ivelin . they were already using it when i started helping with theming. and the request came through to create a mui theme on top of the design system.

@ivelin
Copy link
Contributor

ivelin commented Oct 16, 2022

@brightiron - what was the reason for choosing MUI? What parts of the DS have been implemented already?

thats more of a question for @ivelin . they were already using it when i started helping with theming. and the request came through to create a mui theme on top of the design system.

Hi folks. Sorry for the delay. I was submersed in devcon activities this week. Great time in Bogota.

The choice of MUI was due to:

  • very limited coding capacity
  • Goal to launch a reasonable functional app ASAP
  • MUI’s reputation for a well polished system with reasonable defaults that end users are familiar with across a wide range of devices , modalities and modes.
  • I was aware MUI is not the most friendly system for custom design but I did not want to risk delaying initial release too much. Something functional that just works today is a lot better than something super cool that either half works today or works fine sometime next year.

Happy to discuss switching to a different system after our MMP which is targeted for end of October.

Hope that helps explain the rationale.

@sam-potter
Copy link
Author

@ivelin good to hear you enjoyed devcon. Heard great things about it from everyone.

Your rationale for choosing MUI is perfectly understandable.

In terms of this PR, I'll revert the tailwindcss implementation. I'll pause working further until implementation of the DS into MUI from @brightiron is further along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants