Fix serial corruption on x7 chips #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We never clear LTXOK when we finish transmission of the ring buffer. This means that on the next pass, when new data needs transmission, enabling the Transmit Performed Interrupt fires the interrupt handler immediately, which then proceeds to load data from pointers that are stale as they haven't been set to the correct indexing. - Don't enable Transmit Performed Interrupt prior to setting the correct tail index and prior to loading data in LINDAT reg
|
Hey Spence any word on this? Its been outstanding for a good while now. Would be great to have this in. Thanks! |
SpenceKonde
merged commit 7cdaa11
into
SpenceKonde:v2.0.0-devThis-is-the-head-submit-PRs-against-this
10 of 51 checks passed
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never clear LTXOK when we finish transmission of the ring buffer. This means that on the next pass, when new data needs transmission, enabling the Transmit Performed Interrupt fires the interrupt handler immediately, which then proceeds to load data from pointers that are stale as they haven't been set to the correct index.
Don't enable Transmit Performed Interrupt prior to setting the correct tail index and prior to loading data in LINDAT reg