Fix for broken I2C functionality on x41 chips #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahshah
commented
Feb 16, 2024
ahshah
commented
- CLK/SDA Pins are swapped and comments are misleading
- Pin swap Discussion can be viewed here:
SpenceKonde#833
- Fix recursive call: Wire.cpp in soft master / hw slave
|
Thanks - let's see if this passes tests... |
SpenceKonde
merged commit dc8bad6
into
SpenceKonde:v2.0.0-devThis-is-the-head-submit-PRs-against-this
48 of 55 checks passed
|
Welcome back! |
|
Take a look at the automated test results, something is wrong at 1 MHz with these changes.... https://github.com/SpenceKonde/ATTinyCore/actions/runs/10724961082 |
|
( Icam't test at tje moment as my parts are located at a different site. |
|
I'll try and get to it this week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.