chore: clean up some bad comments

SpecterOps · Jan 9, 2025 · 9d230ee · 9d230ee
1 parent 40aa72c
commit 9d230ee
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 14 deletions.
diff --git a/src/CommonLib/Impersonate.cs b/src/CommonLib/Impersonate.cs
@@ -86,11 +86,11 @@ public class Impersonator : IDisposable {
         /// <summary>
         /// Begins impersonation with the given credentials, Logon type and Logon provider.
         /// </summary>
-        ///<param name = "userName" > Name of the user.</param>
-        ///<param name = "domainName" > Name of the domain.</param>
-        ///<param name = "password" > The password. <see cref = "System.String" /></ param >
-        ///< param name="logonType">Type of the logon.</param>
-        ///<param name = "logonProvider" > The logon provider. <see cref = "Mit.Sharepoint.WebParts.EventLogQuery.Network.LogonProvider" /></param >
+        ///<param name="userName" > Name of the user.</param>
+        ///<param name="domainName" > Name of the domain.</param>
+        ///<param name="password" > The password.</param >
+        ///<param name="logonType">Type of the logon.</param>
+        ///<param name="logonProvider" > The logon provider. <see cref="Mit.Sharepoint.WebParts.EventLogQuery.Network.LogonProvider"/></param >
         public Impersonator(string userName, string domainName, string password, LogonType logonType,
             LogonProvider logonProvider) {
             Impersonate(userName, domainName, password, logonType, logonProvider);

diff --git a/src/CommonLib/Processors/CertAbuseProcessor.cs b/src/CommonLib/Processors/CertAbuseProcessor.cs
@@ -149,10 +149,12 @@ public async Task<AceRegistryAPIResult> ProcessRegistryEnrollmentPermissions(str
         }
 
         /// <summary>
-        /// This function should be called with the enrollment data fetched from <see cref="GetCARegistryValues"/>.
-        /// The resulting items will contain enrollment agent restrictions
+        /// This function will retrieve the enrollment agent restrictions from a ca
         /// </summary>
-        /// <param name="enrollmentAgentRestrictions"></param>
+        /// <param name="caName"></param>
+        /// <param name="objectDomain"></param>
+        /// <param name="computerName"></param>
+        /// <param name="computerObjectId"></param>
         /// <returns></returns>
         public async Task<EnrollmentAgentRegistryAPIResult> ProcessEAPermissions(string caName, string objectDomain, string computerName, string computerObjectId)
         {
@@ -245,7 +247,6 @@ private RegistryResult GetEnrollmentAgentRights(string target, string caName)
         /// <param name="target"></param>
         /// <param name="caName"></param>
         /// <returns></returns>
-        /// <exception cref="Exception"></exception>
         [ExcludeFromCodeCoverage]
         public BoolRegistryAPIResult IsUserSpecifiesSanEnabled(string target, string caName)
         {
@@ -281,7 +282,6 @@ public BoolRegistryAPIResult IsUserSpecifiesSanEnabled(string target, string caN
         /// <param name="target"></param>
         /// <param name="caName"></param>
         /// <returns></returns>
-        /// <exception cref="Exception"></exception>
         [ExcludeFromCodeCoverage]
         public BoolRegistryAPIResult RoleSeparationEnabled(string target, string caName)
         {

diff --git a/src/CommonLib/Processors/DCLdapProcessor.cs b/src/CommonLib/Processors/DCLdapProcessor.cs
@@ -61,8 +61,6 @@ public async Task<LdapService> Scan() {
     /// <summary>
     /// Tests if the specified Ldap port is open
     /// </summary>
-    /// <param name="target">Hostname of the machine</param>
-    /// <param name="target">TCP port being tested</param>
     /// <returns>bool</returns>
     [ExcludeFromCodeCoverage]
     public async Task<bool> TestLdapPort() {

diff --git a/src/CommonLib/Processors/DCRegistryProcessor.cs b/src/CommonLib/Processors/DCRegistryProcessor.cs
@@ -24,7 +24,6 @@ public DCRegistryProcessor(ILdapUtils utils, ILogger log = null)
         /// <remarks>https://support.microsoft.com/en-us/topic/kb5014754-certificate-based-authentication-changes-on-windows-domain-controllers-ad2c23b0-15d8-4340-a468-4d4f3b188f16</remarks>
         /// <param name="target"></param>
         /// <returns>IntRegistryAPIResult</returns>
-        /// <exception cref="Exception"></exception>
         [ExcludeFromCodeCoverage]
         public IntRegistryAPIResult GetCertificateMappingMethods(string target)
         {
@@ -57,7 +56,6 @@ public IntRegistryAPIResult GetCertificateMappingMethods(string target)
         /// <remarks>https://support.microsoft.com/en-us/topic/kb5014754-certificate-based-authentication-changes-on-windows-domain-controllers-ad2c23b0-15d8-4340-a468-4d4f3b188f16</remarks>
         /// <param name="target"></param>
         /// <returns>IntRegistryAPIResult</returns>
-        /// <exception cref="Exception"></exception>
         [ExcludeFromCodeCoverage]
         public IntRegistryAPIResult GetStrongCertificateBindingEnforcement(string target)
         {