Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bed-2143 chore: add warning detection for non-unique emails #1087

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mistahj67
Copy link
Contributor

@mistahj67 mistahj67 commented Jan 17, 2025

Description

  • Add warning logs for non-unique emails
  • Fixed missing license files
  • Added duplicate enforcement to create and update user endpoints
  • Added handling to UI for email conflict
  • Added warning display on Users tab of admin panel if duplicate emails are detected
  • Updated db method to store lowercase emails to prevent case-sensitive edge cases

Motivation and Context

This PR addresses: BED-2143

Why is this change required? What problem does it solve?

How Has This Been Tested?

Locally

Types of changes

  • Chore (a change that does not modify the application functionality)

Checklist:

@mistahj67 mistahj67 added the api A pull request containing changes affecting the API code. label Jan 17, 2025
@mistahj67 mistahj67 self-assigned this Jan 17, 2025
@mistahj67 mistahj67 added the user interface A pull request containing changes affecting the UI code. label Jan 23, 2025
@mistahj67 mistahj67 force-pushed the BED-2143 branch 2 times, most recently from 81ea29e to d7c03fc Compare January 23, 2025 01:55
Copy link
Contributor

@wes-mil wes-mil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this PR requires a migration to convert all existing email addresses to lowercase, as the check performed in IsNewEmail relies on a lowercase assumption

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api A pull request containing changes affecting the API code. user interface A pull request containing changes affecting the UI code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants