CoerceAndRelayNTLMtoADCS Post Processing #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esting of end nodes in NTLM integration test
…ED-5029 # Conflicts: # packages/cue/bh/ad/ad.cue # packages/go/analysis/ad/adcs.go # packages/go/analysis/ad/ntlm.go # packages/go/graphschema/ad/ad.go # packages/javascript/bh-shared-ui/src/graphSchema.ts
…tab depth in if blocks
# Conflicts: # packages/cue/bh/ad/ad.cue # packages/go/analysis/ad/ntlm.go # packages/go/graphschema/ad/ad.go # packages/javascript/bh-shared-ui/src/graphSchema.ts
# Conflicts: # packages/go/analysis/ad/adcscache.go # packages/go/graphschema/ad/ad.go # packages/javascript/bh-shared-ui/src/graphSchema.ts
rvazarkar
changed the title
mvlipka
approved these changes
Jan 30, 2025
mistahj67
reviewed
Jan 30, 2025
Comment on lines
+74
to
+79
| if enterpriseCertAuthorities, err := FetchNodesByKind(ctx, db, ad.EnterpriseCA); err != nil { | ||
| return fmt.Errorf("failed fetching enterpriseCA nodes: %w", err) | ||
| } else if certTemplates, err := FetchNodesByKind(ctx, db, ad.CertTemplate); err != nil { | ||
| return fmt.Errorf("failed fetching certTemplate nodes: %w", err) | ||
| } else if domains, err := FetchNodesByKind(ctx, db, ad.Domain); err != nil { | ||
| return fmt.Errorf("failed fetching domain nodes: %w", err) |
There was a problem hiding this comment.
Not sure which is faster, 3 separate fetch nodes by kind or 1 fetch with these 3 kinds and then loop the results and have a switch case based on the node kind and the 3 separate actions as either smaller functions or just toss each of the below blocks into the case. Might be 6 one way, half a dozen the other but thought I'd toss the idea out
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail
Motivation and Context
This PR addresses: https://specterops.atlassian.net/browse/BED-5029
How Has This Been Tested?
Integration tests created to test specific harnesses
Screenshots (optional):
Types of changes
Checklist: