Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native spicemix #310

Merged
merged 6 commits into from
Jul 4, 2024
Merged

Native spicemix #310

merged 6 commits into from
Jul 4, 2024

Conversation

peicai
Copy link
Contributor

@peicai peicai commented Jun 25, 2024

  • Specify the preprocess parameter in the configs to ensure preprocessing is performed within the script.
  • It seems the pipeline doesn't use PCA, despite finding the _pca function; I didn't add it.
  • I encountered an error while attempting to run on CPU due to lack of GPU access:
Traceback (most recent call last):
  File "/home/jovyan/scratch/SpaceHack2/userfolders/pcai/SpaceHack2023/native_implementation/SpaceHack2023/method/SpiceMix/SpiceMix.py", line 187, in <module>
    model = SpiceMix(
  File "/home/jovyan/conda_envs/test_SpiceMix/lib/python3.8/site-packages/popari/model.py", line 459, in __init__
    super().__init__(spatial_affinity_mode="shared lookup", **spicemix_hyperparameters)
TypeError: __init__() got an unexpected keyword argument 'device'

with torch_context = `{'device': 'cpu', 'dtype': torch.float64}, which might be related to issues: #225 and #231. I'll leave it as is for now and will test it on the cluster.

@peicai peicai requested review from shdam and Jieran-S June 25, 2024 14:04
@kbiharie kbiharie merged commit 3cbb918 into native Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants