Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release instructions to README #123

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add release instructions to README #123

wants to merge 3 commits into from
+16 −0

Conversation

rnestler
Copy link
Member

No description provided.

@rnestler rnestler requested a review from a team December 31, 2024 16:37
@rnestler rnestler mentioned this pull request Dec 31, 2024
Merged
@rnestler rnestler force-pushed the add-release-instructions-to-README branch from 98c09cd to 1179e4d Compare December 31, 2024 16:45
@rnestler rnestler requested review from dbrgn and gidsi January 6, 2025 08:58
@rnestler rnestler requested a review from s3lph January 26, 2025 15:13
s3lph
s3lph reviewed Jan 26, 2025
View reviewed changes
Copy link
Member

@s3lph s3lph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we encounter some issues with the new version of the validator not being pushed to Docker Hub? Is there a manual step needed there as well, or has this issue been resolved?

Apart from that, looks good to me, but could be that I'm missing something.

dbrgn
dbrgn approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@dbrgn dbrgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. Maybe we forgot some things, but we'll notice and update next time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s3lph s3lph s3lph left review comments

@dbrgn dbrgn dbrgn approved these changes

@gidsi gidsi Awaiting requested review from gidsi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rnestler @dbrgn @s3lph