Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hackspace Siegen: Update domain #276

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Hackspace Siegen: Update domain #276

merged 1 commit into from
Jan 16, 2025

Conversation

devn1x
Copy link
Contributor

@devn1x devn1x commented Jan 16, 2025

We switched to our newer domain ha.si. The old domain is redirected, but that may result in CORS errors, for example on https://mapall.space. This should fix this.

@devn1x
Update directory.json
a83e23f 
We switched to our newer domain. The old domain is redirected, but that can results in CORS errors. This should fix this.
@devn1x devn1x changed the title Update our domain Hackspace Siegen: Update domain Jan 16, 2025
s3lph
s3lph approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@s3lph s3lph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, and thanks for the update.

While you're at it, you might want to consider adding support for SpaceAPI v14. In the case of your endpoint, it's as simple as adding the top-level key "api_compatibility": ["14"].

@s3lph s3lph merged commit 7c8de22 into SpaceApi:master Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s3lph s3lph s3lph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devn1x @s3lph