Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Linux User Group Saar entry in directory #251

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

informaniac
Copy link
Contributor

Hello everyone. With this pull request we want to update our entry in the directory since we now host the space.api json file on our webspace.

Thanks in advance,
LUG Saar

@dbrgn
Copy link
Contributor

dbrgn commented Feb 15, 2024

Nice!

As indicated by the validator (https://validator.spaceapi.io/ui/?url=https://lugsaar.de/spaceapi/api.json), could you maybe add CORS headers to your endpoint, so it is reachable from the browser? A simple access-control-allow-origin: * header should suffice.

@informaniac
Copy link
Contributor Author

hi dbrgn,

thanks for the quick response. we should have fixed it now. at least the validator does not complain anymore

@dbrgn
Copy link
Contributor

dbrgn commented Feb 15, 2024

Perfect, thanks!

@dbrgn dbrgn merged commit f5e1936 into SpaceApi:master Feb 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants