Make command test a little cleaner

- clearer ordering of methods
- messages on assertions to help with failures

test/EnvironmentConfigurationCommandTest.php

@@ -18,14 +18,6 @@ class EnvironmentConfigurationCommandTest extends TestCase
     /** @var EnvironmentConfigurationCommand */
     private $subject;
 
-    public function testConfigure()
-    {
-        self::assertEquals(
-            EnvironmentConfigurationCommand::COMMAND_NAME,
-            $this->subject->getName()
-        );
-    }
-
     public function testExecuteFailure()
     {
         $input = $this->getMockForAbstractClass(InputInterface::class);
@@ -45,41 +37,65 @@ public function testExecuteSuccess()
             ->with('environment')
             ->willReturn(Environment::STAGING);
 
-        self::assertEquals(0, $this->subject->execute($input, $output));
+        self::assertEquals(
+            0,
+            $this->subject->execute($input, $output),
+            'Given a valid environment the command should execute and return 0'
+        );
+    }
 
+    public function testConfigure()
+    {
+        self::assertEquals(
+            EnvironmentConfigurationCommand::COMMAND_NAME,
+            $this->subject->getName()
+        );
     }
 
     protected function setUp()
     {
-        $mockConfigWriter = new class implements WriterInterface
+        $this->subject = new EnvironmentConfigurationCommand(
+            new ConfigValueRepository($this->getDummyConfigWriter()),
+            $this->getEmptyConfig()
+        );
+    }
+
+    private function getDummyConfigWriter(): WriterInterface
+    {
+        return new class implements WriterInterface
         {
             public function delete(
                 $path,
                 $scope = ScopeConfigInterface::SCOPE_TYPE_DEFAULT,
                 $scopeId = 0
-            ) {
+            )
+            {
+                // do nothing
             }
 
             public function save(
                 $path,
                 $value,
                 $scope = ScopeConfigInterface::SCOPE_TYPE_DEFAULT,
                 $scopeId = 0
-            ) {
+            )
+            {
+                // do nothing
             }
         };
+    }
 
-        $emptyConfig = new class implements EnvironmentConfigValuesProvider
+    /**
+     * @return EnvironmentConfigValuesProvider
+     */
+    protected function getEmptyConfig()
+    {
+        return new class implements EnvironmentConfigValuesProvider
         {
             public function getValues(): EnvironmentConfigValues
             {
                 return EnvironmentConfigValues::create();
             }
         };
-
-        $this->subject = new EnvironmentConfigurationCommand(
-            new ConfigValueRepository($mockConfigWriter),
-            $emptyConfig
-        );
     }
-}
+}