Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support both celestia and mock (default) for sov-rollup-starter #11

Merged
merged 7 commits into from
Nov 13, 2023

Conversation

dubbelosix
Copy link
Contributor

Summary

Currently sov-rollup-starter is only buit with support for mock. This PR adds support for celestia-da. It uses feature flags so the starter can be built with either celestia or mock (as opposed to being built with both and using runtime flags).

Changes

  • docker structure imported from sovereign
  • docker related steps from sovereign repo added to make file
  • feature flags for building StarterRollup with either celestia-da or mock-da
  • Readme modified with a second section for Celestia support. Original section is intact to let new developers build easily with mock
  • test-data, config, genesis imported from sovereign as well

Remaining work

It would be ideal to have the docker related files and code not duplicated between sovereign-sdk and sov-rollup-starter. This work will be merged into separating the DA adapters into their own repos (since the general structure is similar - make them git submodules (or subprepos) and then reuse them in sovereign and sov-rollup-starter

crates/rollup/Cargo.toml Outdated Show resolved Hide resolved
bkolad
bkolad previously approved these changes Nov 13, 2023
Copy link
Member

@bkolad bkolad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also test the Celestia rollup it CI (in a separate PR)

@dubbelosix dubbelosix merged commit 3fa9460 into main Nov 13, 2023
1 check passed
soareschen referenced this pull request in informalsystems/sov-rollup-starter Mar 26, 2024
Upgrade sov-rollup-starter-wip to latest sovereign-sdk-wip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants