-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JWT authentication #239
base: master
Are you sure you want to change the base?
JWT authentication #239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As someone that is currently utilizing https://github.com/hayfever/sorcery-jwt for tokens, I would love to see this move forward. I currently have a snag with the mentioned gem and oauth. When a user logs in with a provider (i.e. Twitter), I am not getting a token. I suspect JWT being "baked" into Sorcery would allow for that...
@sqlninja I'm about to look into this for Sorcery v1, one thing that I would like to know is if the community would prefer this to be a part of To @alexeyramazanov, @hayfever, @wilddima, @ebihara99999: would any of you be willing to assist me in implementing this in Sorcery v1? Being pointed at the right documentation for JWT, as well as having the perspective of someone who already uses it would both be incredibly helpful for me. Whatever we design, I want to ensure it is interoperable with other plugins (e.g. |
I would agree that a plugin seems to make the most sense - I enjoy the modularity of sorcery even if a lot of the plugins end up getting used as "defaults". I would definitely be willing to help where needed - I will say that I haven't been using my extension for quite a while as I had written it solely to authenticate a mobile app in a previous project I was working on. The project I'm now working on (unfortunately) uses devise so I've been out of the sorcery world for a little while, too. |
I created a new issue on the rework repo for discussing the JWT implementation, anyone who wants to help is welcome to comment there: Sorcery/sorcery-rework#9 |
As it's written - JWT support for sorcery.
Partially based on #70 and #167.