[Feature/#70] 내 정보 관리 페이지 & api 구현 #92
Open
+806
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
HI-JIN2
approved these changes
Jan 13, 2025
| final TextInputType keyboardType; | ||
|
|
||
| /// 수정 가능 여부 체크 | ||
| final bool readOnly; |
There was a problem hiding this comment.
isEditable 이런건 어떨까유 수정 가능 여부면은 true일때 수정이 가능한게 좀더 자연스러워 보여욥
Comment on lines
+238
to
+247
| /// 인증 완료 다이얼로그 | ||
| void showSnackbar(BuildContext context, String text) { | ||
| ScaffoldMessenger.of(context).showSnackBar( | ||
| SnackBar( | ||
| content: Text(text, style: CogoTextStyle.body14), | ||
| backgroundColor: Colors.white, | ||
| duration: const Duration(seconds: 4), | ||
| ), | ||
| ); | ||
| } |
There was a problem hiding this comment.
이거 스낵바도 util로 만들어두면 좋을 것 같아요~
There was a problem hiding this comment.
위젯 말고 util로 만드나요?
There was a problem hiding this comment.
상관 없서요~ 유틸로 만들라는 의미가 한줄로 string 값만 받아서 사용할 수 있도록 만들어서 쓰면 좋지 않을까~ 였습니다
혹시 어떻게 넓다는 말씀이실까욥? |
제가 봤을때는 tag랑 스펙이 같은걸로 보이는데, 구현상으로는 ThirdButton의 마진이나 패딩이 좀 넓어보여서요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
코드 구조 요약
MyInfoScreen (UI)
MyInfoViewModel (로직 & 상태 관리)
TODO
현재 코드에서 updateUserInfo(), 서버에게 사용자 정보 patch하기가 작동하지 않습니다.
계속해서 302 오류가 뜨는데 서버분들께서 확인하신 후 추후 고치도록 하겠습니다.
Screenshot
Screen_recording_20250110_035716.mp4
💬 리뷰 요구사항(선택)
현재 재전송 제한 시간을 3분으로 설정해놨는데 몇 분 정도로 해야 적당한지 고민입니다!