SONARPHP-1570 Symbols should be created for tree inside PropertyHooks…

… in constructor functions (#1316)
SonarSource · Nov 14, 2024 · 1eac839 · 1eac839
1 parent 91df795
commit 1eac839
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/php-frontend/src/main/java/org/sonar/php/tree/symbols/SymbolVisitor.java b/php-frontend/src/main/java/org/sonar/php/tree/symbols/SymbolVisitor.java
@@ -405,6 +405,11 @@ public void visitParameter(ParameterTree tree) {
     if (initValue != null) {
       initValue.accept(this);
     }
+
+    var propertyHookListTree = tree.propertyHookList();
+    if (propertyHookListTree != null) {
+      scan(propertyHookListTree);
+    }
     // do not scan the children to not pass through variableIdentifier
   }
 

diff --git a/php-frontend/src/test/java/org/sonar/php/tree/symbols/SymbolTableImplTest.java b/php-frontend/src/test/java/org/sonar/php/tree/symbols/SymbolTableImplTest.java
@@ -552,7 +552,7 @@ void constantDeclaration() {
   }
 
   @Test
-  void shouldCreateSymbolForFunctionInPropertyHook() {
+  void shouldCreateSymbolForFunctionInVariableDeclarationPropertyHook() {
     SymbolTableImpl symbolTable = symbolTableFor("<?php class A { public int $prop { get { return isset($this->prop2); } } }");
 
     Symbol symbol = symbolTable.getSymbol("isset");
@@ -561,6 +561,24 @@ void shouldCreateSymbolForFunctionInPropertyHook() {
     assertThat(symbol.usages()).hasSize(1);
   }
 
+  @Test
+  void shouldCreateSymbolForFunctionInParameterPropertyHook() {
+    SymbolTableImpl symbolTable = symbolTableFor("""
+      <?php
+      class A {
+        public function __construct(
+          public $prop = 42 {
+            get => isset($this->prop);
+          }
+        ) { }
+      }""");
+
+    Symbol symbol = symbolTable.getSymbol("isset");
+    assertThat(symbol).isInstanceOf(UndeclaredSymbol.class);
+    assertThat(symbol.is(Symbol.Kind.FUNCTION)).isTrue();
+    assertThat(symbol.usages()).hasSize(1);
+  }
+
   private static void assertClassSymbols(SymbolTableImpl symbolTable, String... fullyQualifiedNames) {
     assertThat(symbolTable.getSymbols(Kind.CLASS)).extracting(s -> s.qualifiedName().toString())
       .containsExactly(fullyQualifiedNames);