Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gateway contract locations from Assets #986

Merged
merged 16 commits into from
Nov 3, 2023

Conversation

alistair-singh
Copy link
Contributor

@alistair-singh alistair-singh commented Nov 2, 2023

Resolves: SNO-735

Polkadot-Sdk companion: Snowfork/polkadot-sdk#12

TODO

  • Fix unit tests

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (59c657f) 82.41% compared to head (726ca1a) 82.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
+ Coverage   82.41%   82.51%   +0.10%     
==========================================
  Files          51       51              
  Lines        2081     2065      -16     
  Branches       71       71              
==========================================
- Hits         1715     1704      -11     
+ Misses        350      345       -5     
  Partials       16       16              
Flag Coverage Δ
rust 83.74% <86.95%> (+0.13%) ⬆️
solidity 76.73% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
contracts/src/Assets.sol 67.85% <100.00%> (ø)
parachain/primitives/router/src/inbound/mod.rs 56.47% <86.95%> (-1.95%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alistair-singh alistair-singh force-pushed the alistair/remove-gateway-contract-locations branch 3 times, most recently from 69b334f to ee05010 Compare November 2, 2023 11:55
@alistair-singh alistair-singh force-pushed the alistair/remove-gateway-contract-locations branch from 9a0ac48 to e7ab5b8 Compare November 3, 2023 01:39
@alistair-singh alistair-singh force-pushed the alistair/remove-gateway-contract-locations branch from e7ab5b8 to 2df0b2d Compare November 3, 2023 10:16
Base automatically changed from reserve-asset-transfer to main November 3, 2023 10:23
@alistair-singh alistair-singh force-pushed the alistair/remove-gateway-contract-locations branch from 2df0b2d to 3e5e56b Compare November 3, 2023 10:26
@alistair-singh alistair-singh merged commit ab6d7a0 into main Nov 3, 2023
6 checks passed
@alistair-singh alistair-singh deleted the alistair/remove-gateway-contract-locations branch November 3, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants