Polkadot SDK Update #965
Closed
Polkadot SDK Update #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
September 8, 2023 15:02
This was referenced Sep 20, 2023
Closed
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #965 +/- ##
==========================================
+ Coverage 75.23% 76.61% +1.37%
==========================================
Files 41 41
Lines 1813 1924 +111
Branches 75 75
==========================================
+ Hits 1364 1474 +110
- Misses 429 430 +1
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
* adds transfer token test * assert agent id is the source * complete transfer token test --------- Co-authored-by: claravanstaden <Cats 4 life!> Co-authored-by: Alistair Singh <[email protected]>
claravanstaden
commented
Sep 26, 2023
Comment on lines
+33
to
+37
| let origin = | ||
| T::AgentOrigin::try_successful_origin().map_err(|_| BenchmarkError::Weightless)?; | ||
|
|
||
| #[extrinsic_call] | ||
| _(RawOrigin::Signed(caller)); | ||
| _(origin as T::RuntimeOrigin); |
There was a problem hiding this comment.
This seems to be the way to handle origin checking in benchmarks.
added 9 commits
September 29, 2023 13:02
|
Closing in favour of #972. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polkadot SDK companion: Snowfork/polkadot-sdk#2